Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] Wrap inference service in avatar for dark mode support (#212092) #212164

Merged
merged 1 commit into from
Feb 22, 2025
+10 −12
Merged

[8.18] Wrap inference service in avatar for dark mode support (#212092) #212164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .../shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,6 @@ export const InferenceServiceFormFields: React.FC<InferenceServicesProps> = ({
}
}, []);

const providerIcon = useMemo(
() =>
Object.keys(SERVICE_PROVIDERS).includes(config?.provider)
? SERVICE_PROVIDERS[config?.provider as ServiceProviderKeys].icon
: undefined,
[config?.provider]
);

const providerName = useMemo(
() =>
Object.keys(SERVICE_PROVIDERS).includes(config?.provider)
Expand Down Expand Up @@ -252,7 +244,7 @@ export const InferenceServiceFormFields: React.FC<InferenceServicesProps> = ({
isDisabled={isEdit}
isInvalid={isInvalid}
fullWidth
icon={!config?.provider ? { type: 'sparkles', side: 'left' } : providerIcon}
icon={!config?.provider ? { type: 'sparkles', side: 'left' } : undefined}
>
<EuiFieldText
onClick={toggleProviderPopover}
Expand All @@ -278,7 +270,6 @@ export const InferenceServiceFormFields: React.FC<InferenceServicesProps> = ({
isEdit,
onClearProvider,
config?.provider,
providerIcon,
toggleProviderPopover,
handleProviderKeyboardOpen,
providerName,
Expand Down
11 changes: 9 additions & 2 deletions ...-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { EuiHighlight, EuiIcon } from '@elastic/eui';
import { EuiAvatar, EuiHighlight } from '@elastic/eui';
import React from 'react';

import { ServiceProviderKeys } from '../../../constants';
Expand Down Expand Up @@ -118,7 +118,14 @@ export const ServiceProviderIcon: React.FC<ServiceProviderProps> = ({ providerKe
const provider = SERVICE_PROVIDERS[providerKey];

return provider ? (
<EuiIcon data-test-subj={`icon-service-provider-${providerKey}`} type={provider.icon} />
<EuiAvatar
name={providerKey}
data-test-subj={`icon-service-provider-${providerKey}`}
iconType={provider.icon}
color="#fff"
size="s"
type="space"
/>
) : null;
};

Expand Down