From ec8601b846dacdf354354da94fb593d1f2dcafca Mon Sep 17 00:00:00 2001 From: Michael DeFazio Date: Fri, 21 Feb 2025 09:31:46 -0500 Subject: [PATCH 1/6] Wrap inference service in avatar for dark mode support --- .../providers/render_service_provider/service_provider.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx index f5e379f94e85b..f2408398fe2e6 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx @@ -5,7 +5,7 @@ * 2.0. */ -import { EuiHighlight, EuiIcon } from '@elastic/eui'; +import { EuiAvatar, EuiHighlight, EuiIcon } from '@elastic/eui'; import React from 'react'; import { ServiceProviderKeys } from '../../../constants'; @@ -118,7 +118,8 @@ export const ServiceProviderIcon: React.FC = ({ providerKe const provider = SERVICE_PROVIDERS[providerKey]; return provider ? ( - + + // ) : null; }; From c8e2e0f9eef1355928fe711e2b60a8b4c8f38981 Mon Sep 17 00:00:00 2001 From: Michael DeFazio Date: Fri, 21 Feb 2025 09:39:03 -0500 Subject: [PATCH 2/6] Removes commented line --- .../providers/render_service_provider/service_provider.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx index f2408398fe2e6..201e8ccdb7d6b 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx @@ -119,7 +119,6 @@ export const ServiceProviderIcon: React.FC = ({ providerKe return provider ? ( - // ) : null; }; From d4f3916e8262d8f5cfa258c20f0c806945f5b037 Mon Sep 17 00:00:00 2001 From: Michael DeFazio Date: Fri, 21 Feb 2025 10:42:00 -0500 Subject: [PATCH 3/6] Removes selected icon in input field --- .../src/components/inference_service_form_fields.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx index f6e5845f4a889..ee89e67c1942c 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx @@ -252,7 +252,7 @@ export const InferenceServiceFormFields: React.FC = ({ isDisabled={isEdit} isInvalid={isInvalid} fullWidth - icon={!config?.provider ? { type: 'sparkles', side: 'left' } : providerIcon} + icon={!config?.provider ? { type: 'sparkles', side: 'left' } : null} > Date: Fri, 21 Feb 2025 16:58:31 +0000 Subject: [PATCH 4/6] [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' --- .../render_service_provider/service_provider.tsx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx index 201e8ccdb7d6b..a1aa8a614164f 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx @@ -5,7 +5,7 @@ * 2.0. */ -import { EuiAvatar, EuiHighlight, EuiIcon } from '@elastic/eui'; +import { EuiAvatar, EuiHighlight } from '@elastic/eui'; import React from 'react'; import { ServiceProviderKeys } from '../../../constants'; @@ -118,7 +118,14 @@ export const ServiceProviderIcon: React.FC = ({ providerKe const provider = SERVICE_PROVIDERS[providerKey]; return provider ? ( - + ) : null; }; From 6e41cb9e8bd89676fa290ecb9c86b7200d2afd32 Mon Sep 17 00:00:00 2001 From: Samiul Monir Date: Fri, 21 Feb 2025 13:20:28 -0500 Subject: [PATCH 5/6] fixing type and linting issues --- .../src/components/inference_service_form_fields.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx index ee89e67c1942c..f312758a1c14d 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx @@ -252,7 +252,7 @@ export const InferenceServiceFormFields: React.FC = ({ isDisabled={isEdit} isInvalid={isInvalid} fullWidth - icon={!config?.provider ? { type: 'sparkles', side: 'left' } : null} + icon={!config?.provider ? { type: 'sparkles', side: 'left' } : undefined} > = ({ isEdit, onClearProvider, config?.provider, - providerIcon, toggleProviderPopover, handleProviderKeyboardOpen, providerName, From 699349806adb63b6ccf8cf655b0930521ea41fe2 Mon Sep 17 00:00:00 2001 From: Samiul Monir Date: Fri, 21 Feb 2025 14:39:07 -0500 Subject: [PATCH 6/6] Removed unused variable declarations --- .../src/components/inference_service_form_fields.tsx | 8 -------- 1 file changed, 8 deletions(-) diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx index f312758a1c14d..13add8317412a 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx @@ -97,14 +97,6 @@ export const InferenceServiceFormFields: React.FC = ({ } }, []); - const providerIcon = useMemo( - () => - Object.keys(SERVICE_PROVIDERS).includes(config?.provider) - ? SERVICE_PROVIDERS[config?.provider as ServiceProviderKeys].icon - : undefined, - [config?.provider] - ); - const providerName = useMemo( () => Object.keys(SERVICE_PROVIDERS).includes(config?.provider)