Wrap inference service in avatar for dark mode support #212092
Merged
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samiul-TheSoccerFan
added
release_note:skip
mdefazio
force-pushed
the
inference-service-logos
branch
from
07e72be to
d4f3916
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
spong
approved these changes
Feb 21, 2025
Samiul-TheSoccerFan
approved these changes
Feb 21, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 21, 2025
## Summary Wraps the logos in our service provider list in an avatar so they are visible in dark mode.  This does not change the selected state for a provider. These logos will still look poorly in dark mode, but this seemed like a larger effort (perhaps someone can help make that more seamless). We could also just remove the logo when selected. The logos are beneficial when finding a preferred service, but possibly less so once I've chosen one.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Samiul Monir <samiul.monir@elastic.co> (cherry picked from commit 1a9315c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 21, 2025
## Summary Wraps the logos in our service provider list in an avatar so they are visible in dark mode.  This does not change the selected state for a provider. These logos will still look poorly in dark mode, but this seemed like a larger effort (perhaps someone can help make that more seamless). We could also just remove the logo when selected. The logos are beneficial when finding a preferred service, but possibly less so once I've chosen one.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Samiul Monir <samiul.monir@elastic.co> (cherry picked from commit 1a9315c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 21, 2025
## Summary Wraps the logos in our service provider list in an avatar so they are visible in dark mode.  This does not change the selected state for a provider. These logos will still look poorly in dark mode, but this seemed like a larger effort (perhaps someone can help make that more seamless). We could also just remove the logo when selected. The logos are beneficial when finding a preferred service, but possibly less so once I've chosen one.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Samiul Monir <samiul.monir@elastic.co> (cherry picked from commit 1a9315c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2025
#212166) # Backport This will backport the following commits from `main` to `9.0`: - [Wrap inference service in avatar for dark mode support (#212092)](#212092) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Michael DeFazio","email":"michael.defazio@elastic.co"},"sourceCommit":{"committedDate":"2025-02-21T22:25:54Z","message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-elasticsearch","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Wrap inference service in avatar for dark mode support","number":212092,"url":"https://github.com/elastic/kibana/pull/212092","mergeCommit":{"message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212092","number":212092,"mergeCommit":{"message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael DeFazio <michael.defazio@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2025
#212165) # Backport This will backport the following commits from `main` to `8.x`: - [Wrap inference service in avatar for dark mode support (#212092)](#212092) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Michael DeFazio","email":"michael.defazio@elastic.co"},"sourceCommit":{"committedDate":"2025-02-21T22:25:54Z","message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-elasticsearch","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Wrap inference service in avatar for dark mode support","number":212092,"url":"https://github.com/elastic/kibana/pull/212092","mergeCommit":{"message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212092","number":212092,"mergeCommit":{"message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael DeFazio <michael.defazio@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2025
… (#212164) # Backport This will backport the following commits from `main` to `8.18`: - [Wrap inference service in avatar for dark mode support (#212092)](#212092) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Michael DeFazio","email":"michael.defazio@elastic.co"},"sourceCommit":{"committedDate":"2025-02-21T22:25:54Z","message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-elasticsearch","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Wrap inference service in avatar for dark mode support","number":212092,"url":"https://github.com/elastic/kibana/pull/212092","mergeCommit":{"message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212092","number":212092,"mergeCommit":{"message":"Wrap inference service in avatar for dark mode support (#212092)\n\n## Summary\n\nWraps the logos in our service provider list in an avatar so they are\nvisible in dark mode.\n\n\n\nThis does not change the selected state for a provider. These logos will\nstill look poorly in dark mode, but this seemed like a larger effort\n(perhaps someone can help make that more seamless).\n\nWe could also just remove the logo when selected. The logos are\nbeneficial when finding a preferred service, but possibly less so once\nI've chosen one.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Samiul Monir <samiul.monir@elastic.co>","sha":"1a9315c07d1e6cad9a1125ac57d0ab001f323f5d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Michael DeFazio <michael.defazio@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wraps the logos in our service provider list in an avatar so they are visible in dark mode.
This does not change the selected state for a provider. These logos will still look poorly in dark mode, but this seemed like a larger effort (perhaps someone can help make that more seamless).
We could also just remove the logo when selected. The logos are beneficial when finding a preferred service, but possibly less so once I've chosen one.