Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [Security Solution][Expandable flyout] add ability for user to resize the flyout and the left/right section even if preview is rendered (#211938) #211966

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

PhilippeOberti
Copy link
Contributor

… the flyout and the left/right section even if preview is rendered (elastic#211938)

## Summary

This PR makes a couple of small changes to the expandable flyout
package:
- get rid of an unwanted white space when preview are shown
- allow the user to resize the flyout and the internal left/right
sections when a preview is rendered

#### White space removal

| Before  | After |
| ------------- | ------------- |
| ![Screenshot 2025-02-20 at 11 17
30 AM](https://github.com/user-attachments/assets/7c7cb817-3fd9-4cac-9f63-5b168c1df832)
| ![Screenshot 2025-02-20 at 11 15
20 AM](https://github.com/user-attachments/assets/6490dda1-e440-41f3-be63-71fd524e736b)
|

#### Allow resize even when previews are shown

https://github.com/user-attachments/assets/034f59c2-6c4a-4efa-a817-8c23dbc11b60

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a4c7c8b)

# Conflicts:
#	x-pack/solutions/security/packages/expandable-flyout/src/components/preview_section.tsx
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 20, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Detection Engine - Security Solution Cypress Tests #1 / Rule actions during detection rule creation Forwards the correct rule type id to the Cases system action Forwards the correct rule type id to the Cases system action

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.8MB 8.8MB -31.0B

History

@PhilippeOberti PhilippeOberti merged commit 6a50956 into elastic:9.0 Feb 20, 2025
12 checks passed
@PhilippeOberti PhilippeOberti deleted the backport/9.0/pr-211938 branch February 20, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants