[Cloud Security] fix fleet form save button bug #211563

alexreal1314 · 2025-02-18T12:27:48Z

Summary

This PR tries to fix the following https://github.com/elastic/security-team/issues/11881
the bug causes a lot of flakiness in our test cases.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed

Closes

this PR closes the above mentioned issues in relation for this ticket - https://github.com/elastic/security-team/issues/11881

Video recording

Screen.Recording.2025-02-17.at.12.53.56.mov

...ications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/index.tsx

elasticmachine · 2025-02-18T16:39:44Z

Pinging @elastic/fleet (Team:Fleet)

JordanSh · 2025-02-18T16:49:59Z

...y/plugins/cloud_security_posture/public/components/fleet_extensions/policy_template_form.tsx

+    updatePolicy(
+      {
+        ...newPolicy,
+        name: currentIntegrationName,
+      },
+      Array.isArray(packagePolicyListByIntegration)
+    );


maybe instead of passing this new parameter just for our use case, and we being a single consumer, we can instead set the formState as not valid (this is already being checked to disable the button) as long as !Array.isArray(packagePolicyListByIntegration)

@JordanSh the problem is that the valid state of the form is triggered from another place and it will cause the button to flicker, disabled -> enabled -> disabled.

kibanamachine · 2025-02-18T18:53:01Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7896

[✅] x-pack/test/fleet_api_integration/config.epm.ts: 25/25 tests passed.
[✅] x-pack/test/fleet_api_integration/config.agent.ts: 25/25 tests passed.
[✅] x-pack/test/fleet_api_integration/config.fleet.ts: 25/25 tests passed.
[✅] x-pack/test/cloud_security_posture_functional/config.agentless.ts: 25/25 tests passed.
[✅] x-pack/test/cloud_security_posture_functional/data_views/config.ts: 25/25 tests passed.
[✅] x-pack/test/cloud_security_posture_api/config.ts: 25/25 tests passed.

see run history

juliaElastic

LGTM

…e enabling save button

added unit test for CspPolicyTemplateForm component

alexreal1314 · 2025-02-20T15:27:02Z

Used additional property 'isFetchedPackagePolicies' to handle enable/disable of save and continue button since formState = 'VALID' before the name input gets the most updated value from our fleet extensions template form.

elasticmachine · 2025-02-20T15:29:00Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

JordanSh · 2025-02-20T15:16:29Z

...y/plugins/cloud_security_posture/public/components/fleet_extensions/policy_template_form.tsx

+        ...newPolicy,
+        name: currentIntegrationName,
+      },
+      Array.isArray(packagePolicyListByIntegration)


i suggest to put this value into a named constant so it will be easier to understand why this check is being done. in this use case maybe something like hasPackagePoliciesLoaded

also, note that an empty array is will still return true for Array.isArray, is this case something we care about? if so, probably good to additionally check for length.

edit: in an offline conversation we figured that an empty array is actually a valid value for us, lets add a comment above this check so its clear to anyone reading it

JordanSh · 2025-02-20T15:44:40Z

...ications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/index.tsx

      updatePackagePolicy(updatedPolicy);
+      setIsFetchedPackagePolicies(isLoadedPackagePolicies);


do other extensions also have this problem? maybe we can pass something more generic like extensionIsLoading, that why every extension can pass what ever fits their case.

…names

kibanamachine · 2025-02-21T22:38:25Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7917

[✅] x-pack/test/fleet_functional/config.ts: 25/25 tests passed.
[✅] x-pack/test/cloud_security_posture_functional/config.ts: 25/25 tests passed.
[✅] x-pack/test/cloud_security_posture_functional/config.agentless.ts: 25/25 tests passed.

see run history

elasticmachine · 2025-02-21T23:08:47Z

💔 Build Failed

Buildkite Build
Commit: a92d068

Failed CI Steps

Test Failures

[job] [logs] Fleet Cypress Tests #1 / Space aware policies creation should allow to update that policy to belong to both test and default space
[job] [logs] Fleet Cypress Tests #1 / Space aware policies creation should redirect to the agent policies list when removing the current space from a policy
[job] [logs] Fleet Cypress Tests #1 / Space aware policies creation the policy should be visible in the default space
[job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy and unhealthy
[job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1330	1331	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	503.8KB	503.8KB	+31.0B
`fleet`	1.7MB	1.7MB	+69.0B
total			+100.0B

Unknown metric groups

API count

id	before	after	diff
`fleet`	1457	1458	+1

History

cc @alexreal1314

kibanamachine · 2025-02-22T08:43:06Z

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13471348180

## Summary This PR tries to fix the following [https://github.com/elastic/security-team/issues/11881](url) the bug causes a lot of flakiness in our test cases. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### Closes this PR closes the above mentioned issues in relation for this ticket - elastic/security-team#11881 ### Video recording https://github.com/user-attachments/assets/b6389216-8078-4f06-9a39-41b9559f8f1b (cherry picked from commit a37b3cf)

kibanamachine · 2025-02-22T08:48:30Z

💚 All backports created successfully

Status	Branch	Result
✅	9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

) # Backport This will backport the following commits from `main` to `9.0`: - [[Cloud Security] fix fleet form save button bug (#211563)](#211563)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Alex Prozorov <alex.prozorov@elastic.co>

alexreal1314 force-pushed the 11881-bug-policy-form-save-button branch from 6c3a9e4 to 9590df3 Compare February 18, 2025 13:53

alexreal1314 changed the title ~~add isFetchedPackagePolicies state to wait for policies to load befor…~~ [Cloud Security] fix fleet form save button bug Feb 18, 2025

alexreal1314 marked this pull request as ready for review February 18, 2025 16:37

alexreal1314 requested review from a team as code owners February 18, 2025 16:37

JordanSh reviewed Feb 18, 2025

View reviewed changes

...ications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/index.tsx Outdated Show resolved Hide resolved

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 18, 2025

JordanSh reviewed Feb 18, 2025

View reviewed changes

juliaElastic approved these changes Feb 19, 2025

View reviewed changes

juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 19, 2025

add isFetchedPackagePolicies state to wait for policies to load befor…

8f832f2

…e enabling save button

alexreal1314 force-pushed the 11881-bug-policy-form-save-button branch from 1af91ab to a8eeeb2 Compare February 20, 2025 12:57

renamed param on that indicates fleet extension state

fda66d9

added unit test for CspPolicyTemplateForm component

alexreal1314 force-pushed the 11881-bug-policy-form-save-button branch from a8eeeb2 to fda66d9 Compare February 20, 2025 13:07

alexreal1314 self-assigned this Feb 20, 2025

alexreal1314 added the Team:Cloud Security Cloud Security team related label Feb 20, 2025

JordanSh approved these changes Feb 20, 2025

View reviewed changes

added comments explaining the changes and renamed to a clearer param …

a92d068

…names

alexreal1314 added release_note:fix bug Fixes for quality problems that affect the customer experience and removed release_note:skip Skip the PR/issue when compiling release notes labels Feb 22, 2025

alexreal1314 merged commit a37b3cf into main Feb 22, 2025
14 checks passed

alexreal1314 deleted the 11881-bug-policy-form-save-button branch February 22, 2025 08:42

kibanamachine added the v9.1.0 label Feb 22, 2025

kibanamachine mentioned this pull request Feb 22, 2025

[9.0] [Cloud Security] fix fleet form save button bug (#211563) #212176

Merged

kibanamachine added the v9.0.0 label Feb 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cloud Security] fix fleet form save button bug #211563

[Cloud Security] fix fleet form save button bug #211563

alexreal1314 commented Feb 18, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Feb 18, 2025

JordanSh Feb 18, 2025

alexreal1314 Feb 19, 2025

kibanamachine commented Feb 18, 2025

juliaElastic left a comment

alexreal1314 commented Feb 20, 2025

elasticmachine commented Feb 20, 2025

JordanSh Feb 20, 2025 •

edited

Loading

JordanSh Feb 20, 2025 •

edited

Loading

kibanamachine commented Feb 21, 2025

elasticmachine commented Feb 21, 2025 •

edited

Loading

API count

kibanamachine commented Feb 22, 2025

kibanamachine commented Feb 22, 2025

		updatePackagePolicy(updatedPolicy);
		setIsFetchedPackagePolicies(isLoadedPackagePolicies);

[Cloud Security] fix fleet form save button bug #211563

[Cloud Security] fix fleet form save button bug #211563

Conversation

alexreal1314 commented Feb 18, 2025 • edited by kibanamachine Loading

Summary

Checklist

Closes

Video recording

elasticmachine commented Feb 18, 2025

JordanSh Feb 18, 2025

Choose a reason for hiding this comment

alexreal1314 Feb 19, 2025

Choose a reason for hiding this comment

kibanamachine commented Feb 18, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7896

juliaElastic left a comment

Choose a reason for hiding this comment

alexreal1314 commented Feb 20, 2025

elasticmachine commented Feb 20, 2025

JordanSh Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

JordanSh Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Feb 21, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7917

elasticmachine commented Feb 21, 2025 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

kibanamachine commented Feb 22, 2025

kibanamachine commented Feb 22, 2025

💚 All backports created successfully

Questions ?

alexreal1314 commented Feb 18, 2025 •

edited by kibanamachine

Loading

JordanSh Feb 20, 2025 •

edited

Loading

JordanSh Feb 20, 2025 •

edited

Loading

elasticmachine commented Feb 21, 2025 •

edited

Loading