[Fix] [Synonyms UI] Fix infinite loading when permissions missing #211530
+169
−46
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| import { EuiEmptyPrompt } from '@elastic/eui'; | ||
| import { FormattedMessage } from '@kbn/i18n-react'; | ||
|
|
||
| const ERROR_MESSAGES = { | ||
| generic: { | ||
| title: ( | ||
| <FormattedMessage id="xpack.search.synonyms.errorTitle" defaultMessage="An error occurred" /> | ||
| ), | ||
| body: ( | ||
| <FormattedMessage | ||
| id="xpack.search.synonyms.errorDescription" | ||
| defaultMessage="An error occured while fetching synonyms. Check Kibana logs for more information." | ||
| /> | ||
| ), | ||
| }, | ||
| missingPermissions: { | ||
| title: ( | ||
| <FormattedMessage | ||
| id="xpack.search.synonyms.missingPermissionsTitle" | ||
| defaultMessage="Missing permissions" | ||
| /> | ||
| ), | ||
| body: ( | ||
| <FormattedMessage | ||
| id="xpack.search.synonyms.missingPermissionsDescription" | ||
| defaultMessage="You do not have the necessary permissions to manage synonyms. Contact your system administrator." | ||
| /> | ||
| ), | ||
| }, | ||
| }; | ||
|
|
||
| export const ErrorPrompt: React.FC<{ errorType: 'missingPermissions' | 'generic' }> = ({ | ||
| errorType, | ||
| }) => { | ||
| return ( | ||
| <EuiEmptyPrompt | ||
| iconType="logoEnterpriseSearch" | ||
| title={<h2>{ERROR_MESSAGES[errorType].title}</h2>} | ||
| body={<p>{ERROR_MESSAGES[errorType].body}</p>} | ||
| /> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import React from 'react'; | ||
| import { SearchSynonymsOverview } from './overview'; | ||
| import { I18nProvider } from '@kbn/i18n-react'; | ||
| import { useFetchSynonymsSets } from '../../hooks/use_fetch_synonyms_sets'; | ||
|
|
||
| jest.mock('../../hooks/use_fetch_synonyms_sets', () => ({ | ||
| useFetchSynonymsSets: jest.fn(() => ({ | ||
| data: undefined, | ||
| isLoading: false, | ||
| isError: true, | ||
| error: { body: { statusCode: 500 } }, | ||
| })), | ||
| })); | ||
|
|
||
| describe('Search Synonyms Overview', () => { | ||
| const queryClient = new QueryClient(); | ||
| const Wrapper = ({ children }: { children?: React.ReactNode }) => ( | ||
| <I18nProvider> | ||
| <QueryClientProvider client={queryClient}>{children}</QueryClientProvider> | ||
| </I18nProvider> | ||
| ); | ||
| it('should show error prompt when we get a generic error', () => { | ||
| render( | ||
| <Wrapper> | ||
| <SearchSynonymsOverview /> | ||
| </Wrapper> | ||
| ); | ||
|
|
||
| expect(screen.getByText('An error occurred')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should show error prompt when we get a missing permissions error', () => { | ||
| (useFetchSynonymsSets as jest.Mock).mockReturnValue({ | ||
| data: undefined, | ||
| isLoading: false, | ||
| isError: true, | ||
| error: { body: { statusCode: 403 } }, | ||
| }); | ||
|
|
||
| render( | ||
| <Wrapper> | ||
| <SearchSynonymsOverview /> | ||
| </Wrapper> | ||
| ); | ||
|
|
||
| expect(screen.getByText('Missing permissions')).toBeInTheDocument(); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're migrating away from this logo, so we may want to use
logoElasticsearchinstead.