Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Remove Legacy the Routes for Job Generation via Saved Object details #44178

Closed
tsullivan opened this issue Aug 27, 2019 · 4 comments
Closed

[Reporting] Remove Legacy the Routes for Job Generation via Saved Object details #44178

tsullivan opened this issue Aug 27, 2019 · 4 comments
Assignees
@joelgriffith
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v7.5.0

Comments

@tsullivan
Copy link
Member

This code should be removed in 8.0 (the next major version): https://github.com/elastic/kibana/blob/a95ae8c/x-pack/legacy/plugins/reporting/server/routes/legacy.ts

In the next versions of 7.x:

  • ensure server logs have the appropriate warnings for calling deprecated code
  • perhaps there should be deprecation headers returned for legacy requests
@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Stack Services labels Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

@tsullivan tsullivan mentioned this issue Aug 27, 2019
Merged
2 tasks
@tsullivan
Copy link
Member Author

We also need to remove test code:

x-pack/test/reporting/es_archives/bwc/6_2/mappings.json
x-pack/test/reporting/es_archives/bwc/6_3/mappings.json

This code is costing some time with maintenance costs to keep up to date with Elasticsearch v8.0.0

@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@bmcconaghy bmcconaghy added Team:Reporting Services and removed Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan
Copy link
Member Author

Closed in #52539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelgriffith joelgriffith

Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v7.5.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsullivan @joelgriffith @bmcconaghy @elasticmachine