diff --git a/x-pack/solutions/observability/plugins/profiling/public/components/frames_summary/index.tsx b/x-pack/solutions/observability/plugins/profiling/public/components/frames_summary/index.tsx index 78ac1cd4111a7..0ad568b170726 100644 --- a/x-pack/solutions/observability/plugins/profiling/public/components/frames_summary/index.tsx +++ b/x-pack/solutions/observability/plugins/profiling/public/components/frames_summary/index.tsx @@ -19,7 +19,7 @@ import { isEmpty } from 'lodash'; import React, { useMemo } from 'react'; import { asCost } from '../../utils/formatters/as_cost'; import { asWeight } from '../../utils/formatters/as_weight'; -import { calculateBaseComparisonDiff } from '../topn_functions/utils'; +import { calculateBaseComparisonDiff, scaleAndRoundValue } from '../topn_functions/utils'; import { SummaryItem } from './summary_item'; interface FrameValue { @@ -41,10 +41,6 @@ const ESTIMATED_VALUE_LABEL = i18n.translate('xpack.profiling.diffTopNFunctions. defaultMessage: 'Estimated value', }) as string; -function getScaleFactor(scaleFactor: number = 1) { - return scaleFactor; -} - export function FramesSummary({ baseValue, comparisonValue, @@ -53,11 +49,14 @@ export function FramesSummary({ compressed = false, }: Props) { const baselineScaledTotalSamples = baseValue - ? baseValue.totalCount * getScaleFactor(baseValue.scaleFactor) + ? scaleAndRoundValue({ value: baseValue.totalCount, scaleFactor: baseValue.scaleFactor }) : 0; const comparisonScaledTotalSamples = comparisonValue - ? comparisonValue.totalCount * getScaleFactor(comparisonValue.scaleFactor) + ? scaleAndRoundValue({ + value: comparisonValue.totalCount, + scaleFactor: comparisonValue.scaleFactor, + }) : 0; const { co2EmissionDiff, costImpactDiff, totalSamplesDiff } = useMemo(() => { diff --git a/x-pack/solutions/observability/plugins/profiling/public/components/normalization_menu/index.tsx b/x-pack/solutions/observability/plugins/profiling/public/components/normalization_menu/index.tsx index 4f31857aa8827..5b39a222a6055 100644 --- a/x-pack/solutions/observability/plugins/profiling/public/components/normalization_menu/index.tsx +++ b/x-pack/solutions/observability/plugins/profiling/public/components/normalization_menu/index.tsx @@ -113,7 +113,7 @@ export function NormalizationMenu(props: Props) { style={{ height: '100%', justifyContent: 'center', - backgroundColor: theme.euiTheme.colors.ghost, + backgroundColor: theme.euiTheme.colors.backgroundBasePlain, padding: '0 16px', }} > diff --git a/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/total_samples_stat.tsx b/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/total_samples_stat.tsx index b4d79c3385560..9efa4011d2b60 100644 --- a/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/total_samples_stat.tsx +++ b/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/total_samples_stat.tsx @@ -9,7 +9,7 @@ import { EuiStat, EuiText } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; import React from 'react'; import { Label } from './label'; -import { scaleValue } from './utils'; +import { scaleAndRoundValue } from './utils'; interface Props { baselineTotalSamples: number; @@ -24,7 +24,7 @@ export function TotalSamplesStat({ comparisonTotalSamples, comparisonScaleFactor, }: Props) { - const scaledBaselineTotalSamples = scaleValue({ + const scaledBaselineTotalSamples = scaleAndRoundValue({ value: baselineTotalSamples, scaleFactor: baselineScaleFactor, }); @@ -44,7 +44,7 @@ export function TotalSamplesStat({ ); } - const scaledComparisonTotalSamples = scaleValue({ + const scaledComparisonTotalSamples = scaleAndRoundValue({ value: comparisonTotalSamples, scaleFactor: comparisonScaleFactor, }); diff --git a/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/utils.ts b/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/utils.ts index 94ca6867c4f14..bfe4f63282f14 100644 --- a/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/utils.ts +++ b/x-pack/solutions/observability/plugins/profiling/public/components/topn_functions/utils.ts @@ -28,10 +28,20 @@ export function getColorLabel(percent: number) { return { color: 'text', label: undefined, icon: undefined }; } -export function scaleValue({ value, scaleFactor = 1 }: { value: number; scaleFactor?: number }) { +function scaleValue({ value, scaleFactor = 1 }: { value: number; scaleFactor?: number }) { return value * scaleFactor; } +export function scaleAndRoundValue({ + value, + scaleFactor = 1, +}: { + value: number; + scaleFactor?: number; +}) { + return Math.round(scaleValue({ value, scaleFactor })); +} + export const getTotalCount = (topNFunctions?: TopNFunctions) => topNFunctions?.selfCPU ?? 0; export interface IFunctionRow {