Skip to content

Commit

Permalink
[8.18] SKA: Fix kebab-case issues in search-kibana packages (#211348) (
Browse files Browse the repository at this point in the history
…#211714)

# Backport

This will backport the following commits from `main` to `8.18`:
- [SKA: Fix kebab-case issues in search-kibana packages
(#211348)](#211348)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-16T08:39:06Z","message":"SKA:
Fix kebab-case issues in search-kibana packages (#211348)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/search-shared-ui` |
`x-pack/solutions/search/packages/shared-ui`\r\n|\r\n\r\n\r\n<details
>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-relocate/utils/transforms.ts\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-repo-packages/package-map.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/solutions/search/packages/shared-ui/jest.config.js\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nx-pack/solutions/search/packages/shared-ui/jest.config.js:14\r\nx-pack/solutions/search/packages/shared-ui/tsconfig.json:2\r\n```\r\n\r\n</details>","sha":"11cd98bfc14ddafc87bc84b6bbe407e9a3b44506","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Fix kebab-case issues in search-kibana
packages","number":211348,"url":"https://github.com/elastic/kibana/pull/211348","mergeCommit":{"message":"SKA:
Fix kebab-case issues in search-kibana packages (#211348)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/search-shared-ui` |
`x-pack/solutions/search/packages/shared-ui`\r\n|\r\n\r\n\r\n<details
>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-relocate/utils/transforms.ts\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-repo-packages/package-map.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/solutions/search/packages/shared-ui/jest.config.js\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nx-pack/solutions/search/packages/shared-ui/jest.config.js:14\r\nx-pack/solutions/search/packages/shared-ui/tsconfig.json:2\r\n```\r\n\r\n</details>","sha":"11cd98bfc14ddafc87bc84b6bbe407e9a3b44506"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211357","number":211357,"state":"MERGED","mergeCommit":{"sha":"e60774c3d8a01171c887e6bdd6bdcfd0ea18d8c5","message":"[9.0]
SKA: Fix kebab-case issues in search-kibana packages (#211348)
(#211357)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.0`:\n- [SKA: Fix kebab-case issues in search-kibana
packages\n(#211348)](https://github.com/elastic/kibana/pull/211348)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by:
Gerard Soldevila
<gerard.soldevila@elastic.co>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211348","number":211348,"mergeCommit":{"message":"SKA:
Fix kebab-case issues in search-kibana packages (#211348)\n\n##
Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules
(plugins and\r\npackages) into a new folder structure, according to the
_Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n>
[!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors
in the error section below (if there are\r\nany).\r\n> * Search for the
`packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource
code (Babel and Eslint config files), and update
them\r\nappropriately.\r\n> * Manually
review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to
ensure that\r\nany CI pipeline customizations continue to be correctly
applied after\r\nthe changed path names\r\n> * Review all of the updated
files, specially the `.ts` and `.js` files\r\nlisted in the sections
below, as some of them contain relative paths\r\nthat have been
updated.\r\n> * Think of potential impact of the move, including tooling
and\r\nconfiguration files that can be pointing to the relocated
modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to
source code\r\n\r\n> [!NOTE]\r\n> * This PR has been
auto-generated.\r\n> * Any manual contributions will be lost if the
'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews
/ approvals before applying manual\r\nfixes, and/or keep your changes in
a .patch / git stash.\r\n> * Please
use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack
channel for feedback.\r\n\r\nAre you trying to rebase this PR to solve
merge conflicts? Please follow\r\nthe steps
describe\r\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\r\n\r\n####
1 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder
|\r\n| -- | ------------- |\r\n| `@kbn/search-shared-ui` |
`x-pack/solutions/search/packages/shared-ui`\r\n|\r\n\r\n\r\n<details
>\r\n<summary>Updated
references</summary>\r\n\r\n```\r\n./package.json\r\n./packages/kbn-relocate/utils/transforms.ts\r\n./packages/kbn-ts-projects/config-paths.json\r\n./src/platform/packages/private/kbn-repo-packages/package-map.json\r\n./tsconfig.base.json\r\n./x-pack/.i18nrc.json\r\n./x-pack/solutions/search/packages/shared-ui/jest.config.js\r\n./yarn.lock\r\n.github/CODEOWNERS\r\n```\r\n\r\n</details><details
>\r\n<summary>Updated relative
paths</summary>\r\n\r\n```\r\nx-pack/solutions/search/packages/shared-ui/jest.config.js:14\r\nx-pack/solutions/search/packages/shared-ui/tsconfig.json:2\r\n```\r\n\r\n</details>","sha":"11cd98bfc14ddafc87bc84b6bbe407e9a3b44506"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/211380","number":211380,"state":"OPEN"}]}]
BACKPORT-->
  • Loading branch information
gsoldevila authored Feb 19, 2025
1 parent d5437f2 commit 7d6e5ba
Show file tree
Hide file tree
Showing 12 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ x-pack/solutions/search/plugins/search_solution/search_navigation @elastic/searc
x-pack/solutions/search/plugins/search_notebooks @elastic/search-kibana
x-pack/solutions/search/plugins/search_playground @elastic/search-kibana
src/platform/packages/shared/kbn-search-response-warnings @elastic/kibana-data-discovery
x-pack/solutions/search/packages/shared_ui @elastic/search-kibana
x-pack/solutions/search/packages/shared-ui @elastic/search-kibana
x-pack/solutions/search/plugins/search_synonyms @elastic/search-kibana
src/platform/packages/shared/kbn-search-types @elastic/kibana-data-discovery
x-pack/platform/plugins/shared/searchprofiler @elastic/kibana-management
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,7 @@
"@kbn/search-notebooks": "link:x-pack/solutions/search/plugins/search_notebooks",
"@kbn/search-playground": "link:x-pack/solutions/search/plugins/search_playground",
"@kbn/search-response-warnings": "link:src/platform/packages/shared/kbn-search-response-warnings",
"@kbn/search-shared-ui": "link:x-pack/solutions/search/packages/shared_ui",
"@kbn/search-shared-ui": "link:x-pack/solutions/search/packages/shared-ui",
"@kbn/search-synonyms": "link:x-pack/solutions/search/plugins/search_synonyms",
"@kbn/search-types": "link:src/platform/packages/shared/kbn-search-types",
"@kbn/searchprofiler-plugin": "link:x-pack/platform/plugins/shared/searchprofiler",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1618,8 +1618,8 @@
"@kbn/search-playground/*": ["x-pack/solutions/search/plugins/search_playground/*"],
"@kbn/search-response-warnings": ["src/platform/packages/shared/kbn-search-response-warnings"],
"@kbn/search-response-warnings/*": ["src/platform/packages/shared/kbn-search-response-warnings/*"],
"@kbn/search-shared-ui": ["x-pack/solutions/search/packages/shared_ui"],
"@kbn/search-shared-ui/*": ["x-pack/solutions/search/packages/shared_ui/*"],
"@kbn/search-shared-ui": ["x-pack/solutions/search/packages/shared-ui"],
"@kbn/search-shared-ui/*": ["x-pack/solutions/search/packages/shared-ui/*"],
"@kbn/search-synonyms": ["x-pack/solutions/search/plugins/search_synonyms"],
"@kbn/search-synonyms/*": ["x-pack/solutions/search/plugins/search_synonyms/*"],
"@kbn/search-types": ["src/platform/packages/shared/kbn-search-types"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
],
"xpack.runtimeFields": "platform/plugins/private/runtime_fields",
"xpack.screenshotting": "platform/plugins/shared/screenshotting",
"xpack.searchSharedUI": "solutions/search/packages/shared_ui",
"xpack.searchSharedUI": "solutions/search/packages/shared-ui",
"xpack.searchHomepage": "solutions/search/plugins/search_homepage",
"xpack.searchIndices": "solutions/search/plugins/search_indices",
"xpack.searchNavigation": "solutions/search/plugins/search_solution/search_navigation",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@

module.exports = {
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/solutions/search/packages/shared_ui',
'<rootDir>/target/kibana-coverage/jest/x-pack/solutions/search/packages/shared-ui',
coverageReporters: ['text', 'html'],
collectCoverageFrom: ['<rootDir>/x-pack/solutions/search/packages/shared_ui/**/*.{ts,tsx}'],
collectCoverageFrom: ['<rootDir>/x-pack/solutions/search/packages/shared-ui/**/*.{ts,tsx}'],
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/search/packages/shared_ui'],
roots: ['<rootDir>/x-pack/solutions/search/packages/shared-ui'],
};
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7101,7 +7101,7 @@
version "0.0.0"
uid ""

"@kbn/search-shared-ui@link:x-pack/solutions/search/packages/shared_ui":
"@kbn/search-shared-ui@link:x-pack/solutions/search/packages/shared-ui":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 7d6e5ba

Please sign in to comment.