Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages/openai: Change default bucket_width and improve documentation #12838

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

packages/openai: Change default bucket_width and improve documentation #12838

wants to merge 5 commits into from

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Feb 19, 2025 •
edited
Loading

Proposed commit message

Reduce data granularity by changing the default bucket width of 1d to 1m (1 day to 1 minute). Have also updated the documentation to clearly mention the collection behaviour, storage implications, how granularity affects, etc.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@shmsr shmsr requested a review from a team as a code owner February 19, 2025 08:15
@shmsr shmsr requested a review from alaudazzi February 19, 2025 08:15
@shmsr shmsr self-assigned this Feb 19, 2025
@shmsr shmsr added documentation Improvements or additions to documentation bugfix Pull request that fixes a bug issue Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Feb 19, 2025
@shmsr shmsr changed the title packages/openai: Fix typo in documentation packages/openai: <TODO TITLE> Feb 19, 2025
@shmsr shmsr changed the title packages/openai: <TODO TITLE> packages/openai: Change default bucket_width and improve documentation Feb 20, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @shmsr

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

@tommyers-elastic tommyers-elastic Awaiting requested review from tommyers-elastic

@daniela-elastic daniela-elastic Awaiting requested review from daniela-elastic

At least 1 approving review is required to merge this pull request.

Assignees

@shmsr shmsr

Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shmsr @elasticmachine