Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Warn LS pipeline should not modify fields coming from EA #1667

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

lucabelluccini
Copy link
Contributor

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.
@lucabelluccini lucabelluccini requested a review from a team as a code owner February 5, 2025 10:27
Copy link

github-actions bot commented Feb 5, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link

github-actions bot commented Feb 5, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request does not have a backport label. Could you fix it @lucabelluccini? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Feb 5, 2025
@lucabelluccini
Copy link
Contributor Author

FYI @kilfoyle / @karenzone

It should be back-ported to any past version.

@kilfoyle
Copy link
Contributor

kilfoyle commented Feb 5, 2025

Hi @lucabelluccini Thanks for opening this! The docs are currently frozen while we migrate to a new system.

I'll look after adding your change into the new system when it's ready, likely in late February.

@kilfoyle kilfoyle self-assigned this Feb 5, 2025
@lucabelluccini
Copy link
Contributor Author

Right 😓 the freeze for the migration. Thanks David

Copy link

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucabelluccini!
The docs are unfrozen now so I'll merge this one and I've opened an issue (#1693) for myself to port this change into the 9.0 docs when they're ready.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit e37bb56 into main Feb 21, 2025
3 of 4 checks passed
mergify bot pushed a commit that referenced this pull request Feb 21, 2025
* [DOCS] Warn LS pipeline should not modify fields coming from EA

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

* Update docs/en/ingest-management/elastic-agent/configuration/outputs/output-logstash.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit e37bb56)
mergify bot pushed a commit that referenced this pull request Feb 21, 2025
* [DOCS] Warn LS pipeline should not modify fields coming from EA

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

* Update docs/en/ingest-management/elastic-agent/configuration/outputs/output-logstash.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit e37bb56)
mergify bot pushed a commit that referenced this pull request Feb 21, 2025
* [DOCS] Warn LS pipeline should not modify fields coming from EA

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

* Update docs/en/ingest-management/elastic-agent/configuration/outputs/output-logstash.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit e37bb56)
kilfoyle pushed a commit that referenced this pull request Feb 21, 2025
… (#1694)

* [DOCS] Warn LS pipeline should not modify fields coming from EA

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

* Update docs/en/ingest-management/elastic-agent/configuration/outputs/output-logstash.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit e37bb56)

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
kilfoyle pushed a commit that referenced this pull request Feb 21, 2025
… (#1695)

* [DOCS] Warn LS pipeline should not modify fields coming from EA

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

* Update docs/en/ingest-management/elastic-agent/configuration/outputs/output-logstash.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit e37bb56)

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
kilfoyle pushed a commit that referenced this pull request Feb 21, 2025
… (#1696)

* [DOCS] Warn LS pipeline should not modify fields coming from EA

Warn LS pipeline should not modify fields coming from EA

Modifying data coming from EA can prevent the ingest pipelines on Elasticsearch side associated to the integrations in use in EA to work correctly.

* Update docs/en/ingest-management/elastic-agent/configuration/outputs/output-logstash.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit e37bb56)

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants