Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use centralized version qualifier #4393

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Jan 30, 2025

What is the problem this PR solves?

To avoid manual invocations specifying the version qualifier for prereleases in this commit we leverage a centralized version of truth for the version qualifier.

How does this PR solve the problem?

Leverages a centralized source of truth version for the version qualifier.

How to test this PR locally

Tested in BK only.
Links:

Snapshot build (9.0.0-SNAPSHOT): https://buildkite.com/elastic/fleet-server-package-mbp/builds/1573#0194b7fc-3802-4341-aa12-7d44f88dcdad
Staging build (9.0.0-beta1): https://buildkite.com/elastic/fleet-server-package-mbp/builds/1573#0194b7fc-3803-4fac-960b-af7edc21453f

To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.
@dliappis dliappis added the ci CI related tasks label Jan 30, 2025
@dliappis dliappis requested a review from pchila January 30, 2025 16:08
@dliappis dliappis self-assigned this Jan 30, 2025
@dliappis dliappis requested a review from a team as a code owner January 30, 2025 16:08
@dliappis dliappis requested review from michalpristas and removed request for a team January 30, 2025 16:08
@dliappis
Copy link
Contributor Author

@jlind23 / @pchila similar question to elastic/beats#42503 (comment); e2e tests failing likely due to lack of dra artifacts for other versions. Good to merge?

@jlind23 jlind23 merged commit 9c57ff4 into elastic:9.0 Jan 30, 2025
7 of 8 checks passed
@dliappis
Copy link
Contributor Author

@pchila will need your help with with forward port to main and backport ports to all 8.x branches

@pchila pchila added forwardport-main backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Jan 30, 2025
@pchila
Copy link
Member

pchila commented Jan 30, 2025

Added the necessary labels... not sure that the backport to 8.18 is working already...

mergify bot pushed a commit that referenced this pull request Jan 30, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)
pkoutsovasilis pushed a commit that referenced this pull request Jan 31, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request Jan 31, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
jlind23 pushed a commit that referenced this pull request Jan 31, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
jlind23 pushed a commit that referenced this pull request Jan 31, 2025
To avoid manual invocations specifying the version qualifier for
prereleases in this commit we leverage a centralized version of
truth for the version qualifier.

(cherry picked from commit 9c57ff4)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify ci CI related tasks forwardport-main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants