Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgraded go-sysinfo #138

Merged
merged 2 commits into from
Apr 11, 2024
Merged

upgraded go-sysinfo #138

merged 2 commits into from
Apr 11, 2024

Conversation

kaanyalti
Copy link
Contributor

@kaanyalti kaanyalti commented Apr 9, 2024 •
edited
Loading

  • Enhancement

What does this PR do?

Upgrades the go-sysinfo package

Why is it important?

Docker dependency in go-sysinfo is removed which resolves some issues.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

Related issues

@kaanyalti kaanyalti requested a review from a team as a code owner April 9, 2024 03:04
@kaanyalti kaanyalti requested review from fearful-symmetry and leehinman and removed request for a team April 9, 2024 03:04
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Apr 9, 2024
leehinman
leehinman approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual changes LGTM

could you update the PR description with why the upgrade is necessary? I'm assuming it is for the Docker stuff, but for historical purposes it would be nice to know what prompted this upgrade.

@kaanyalti kaanyalti merged commit c3b6a62 into elastic:main Apr 11, 2024
5 checks passed
@kaanyalti kaanyalti deleted the upgrade-go-sysinfo branch April 11, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaanyalti @leehinman @pierrehilbert