Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for disk reads and writes per cgroup #121

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add metrics for disk reads and writes per cgroup #121

merged 1 commit into from
Nov 30, 2023

Conversation

ydubreuil
Copy link
Member

@ydubreuil ydubreuil commented Nov 28, 2023 •
edited
Loading

What does this PR do?

This PR adds reads and writes metrics for cgroups V1. Currently, only the total of reads and writes is available and this metric alone is not really useful to understand what is happening inside a container.

Why is it important?

These metrics are important to understand what is happening inside a container running on Kubernetes or Docker and to attribute reads and writes on a host to running containers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

Related issues

@ydubreuil ydubreuil added the enhancement New feature or request label Nov 28, 2023
@ydubreuil ydubreuil requested a review from a team as a code owner November 28, 2023 15:52
@ydubreuil ydubreuil self-assigned this Nov 28, 2023
@ydubreuil ydubreuil requested review from rdner and removed request for a team November 28, 2023 15:52
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 28, 2023
@ydubreuil ydubreuil merged commit 03e3c58 into elastic:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@ydubreuil ydubreuil

Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydubreuil @fearful-symmetry @pierrehilbert