Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs ci switch jk to bk #2898

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Docs ci switch jk to bk #2898

merged 5 commits into from
Feb 8, 2024

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Jan 18, 2024

This PR switches from pushing to master / _ number, to the Buildkite builds conventions: staging / bk.

The _<bk>_ prefixing that really reminds of Buildkite seems weird for Jenkins branches - using _<jk>_ would have been a more obvious approach, however, it would have required updating the preview_cleaner_script to support all 3 flavours:

  • Prod: _
  • Buildkite: bk
  • Jenkins: jk

Given that we anticipate the Jenkins builds won't run for much longer (famous last words), I'm going with simply interverting the Buildkite and Jenkins conventions.

Note - this PR won't get merged until we get the 👍 from @bmorelli25

Deployment order:

Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nkammah nkammah marked this pull request as ready for review February 6, 2024 09:01
@nkammah nkammah requested a review from a team as a code owner February 6, 2024 09:01
@nkammah nkammah force-pushed the docs-ci-switch-jk-to-bk branch from e65dc22 to 7abf626 Compare February 6, 2024 09:24
bmorelli25
bmorelli25 previously approved these changes Feb 6, 2024
export AIR_GAPPED=docker.elastic.co/docs-private/air_gapped:latest
export AIR_GAPPED=docker.elastic.co/docs-private/bk_air_gapped:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change correct for air gapped?

@nkammah nkammah merged commit f54bd62 into master Feb 8, 2024
5 checks passed
@nkammah nkammah deleted the docs-ci-switch-jk-to-bk branch February 8, 2024 05:37
nkammah added a commit to elastic/kibana that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/elasticsearch that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/security-docs that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/apm-pipeline-library that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/logstash that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/ecs that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/kibana that referenced this pull request Feb 8, 2024
## Summary

Following the migration from Jenkins to Buildkite, docs previews are now
available at <repo>_bk_<PR>.
More context in elastic/docs#2898

### Checklist


### Risk Matrix


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 8, 2024
## Summary

Following the migration from Jenkins to Buildkite, docs previews are now
available at <repo>_bk_<PR>.
More context in elastic/docs#2898

### Checklist


### Risk Matrix


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2024
## Summary

Following the migration from Jenkins to Buildkite, docs previews are now
available at <repo>_bk_<PR>.
More context in elastic/docs#2898

### Checklist

### Risk Matrix

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 096bf55)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2024
## Summary

Following the migration from Jenkins to Buildkite, docs previews are now
available at <repo>_bk_<PR>.
More context in elastic/docs#2898

### Checklist

### Risk Matrix

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 096bf55)
bmorelli25 pushed a commit to elastic/security-docs that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/logstash that referenced this pull request Feb 8, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
kibanamachine referenced this pull request in elastic/kibana Feb 8, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [Update docs-preview link
(#176468)](#176468)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nassim
Kammah","email":"nkammah@gmail.com"},"sourceCommit":{"committedDate":"2024-02-08T07:42:35Z","message":"Update
docs-preview link (#176468)\n\n## Summary\r\n\r\nFollowing the migration
from Jenkins to Buildkite, docs previews are now\r\navailable at
<repo>_bk_<PR>.\r\nMore context in
https://github.com/elastic/docs/pull/2898\r\n\r\n###
Checklist\r\n\r\n\r\n### Risk Matrix\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"096bf5515a34f1158a3bd1c0a259388b337f1f68","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.13.0"],"title":"Update
docs-preview
link","number":176468,"url":"https://github.com/elastic/kibana/pull/176468","mergeCommit":{"message":"Update
docs-preview link (#176468)\n\n## Summary\r\n\r\nFollowing the migration
from Jenkins to Buildkite, docs previews are now\r\navailable at
<repo>_bk_<PR>.\r\nMore context in
https://github.com/elastic/docs/pull/2898\r\n\r\n###
Checklist\r\n\r\n\r\n### Risk Matrix\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"096bf5515a34f1158a3bd1c0a259388b337f1f68"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176468","number":176468,"mergeCommit":{"message":"Update
docs-preview link (#176468)\n\n## Summary\r\n\r\nFollowing the migration
from Jenkins to Buildkite, docs previews are now\r\navailable at
<repo>_bk_<PR>.\r\nMore context in
https://github.com/elastic/docs/pull/2898\r\n\r\n###
Checklist\r\n\r\n\r\n### Risk Matrix\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"096bf5515a34f1158a3bd1c0a259388b337f1f68"}}]}]
BACKPORT-->

Co-authored-by: Nassim Kammah <nkammah@gmail.com>
kibanamachine referenced this pull request in elastic/kibana Feb 8, 2024
# Backport

This will backport the following commits from `main` to `7.17`:
- [Update docs-preview link
(#176468)](#176468)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nassim
Kammah","email":"nkammah@gmail.com"},"sourceCommit":{"committedDate":"2024-02-08T07:42:35Z","message":"Update
docs-preview link (#176468)\n\n## Summary\r\n\r\nFollowing the migration
from Jenkins to Buildkite, docs previews are now\r\navailable at
<repo>_bk_<PR>.\r\nMore context in
https://github.com/elastic/docs/pull/2898\r\n\r\n###
Checklist\r\n\r\n\r\n### Risk Matrix\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"096bf5515a34f1158a3bd1c0a259388b337f1f68","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.13.0"],"title":"Update
docs-preview
link","number":176468,"url":"https://github.com/elastic/kibana/pull/176468","mergeCommit":{"message":"Update
docs-preview link (#176468)\n\n## Summary\r\n\r\nFollowing the migration
from Jenkins to Buildkite, docs previews are now\r\navailable at
<repo>_bk_<PR>.\r\nMore context in
https://github.com/elastic/docs/pull/2898\r\n\r\n###
Checklist\r\n\r\n\r\n### Risk Matrix\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"096bf5515a34f1158a3bd1c0a259388b337f1f68"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176468","number":176468,"mergeCommit":{"message":"Update
docs-preview link (#176468)\n\n## Summary\r\n\r\nFollowing the migration
from Jenkins to Buildkite, docs previews are now\r\navailable at
<repo>_bk_<PR>.\r\nMore context in
https://github.com/elastic/docs/pull/2898\r\n\r\n###
Checklist\r\n\r\n\r\n### Risk Matrix\r\n\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"096bf5515a34f1158a3bd1c0a259388b337f1f68"}}]}]
BACKPORT-->

Co-authored-by: Nassim Kammah <nkammah@gmail.com>
ebeahan pushed a commit to elastic/ecs that referenced this pull request Feb 9, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
nkammah added a commit to elastic/elasticsearch that referenced this pull request Feb 13, 2024
Following the migration from Jenkins to Buildkite, docs previews are now available at <repo>_bk_<PR>.

More context in elastic/docs#2898
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Following the migration from Jenkins to Buildkite, docs previews are now
available at <repo>_bk_<PR>.
More context in elastic/docs#2898

### Checklist


### Risk Matrix


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Following the migration from Jenkins to Buildkite, docs previews are now
available at <repo>_bk_<PR>.
More context in elastic/docs#2898

### Checklist


### Risk Matrix


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants