Updating tests

elastic · Feb 13, 2025 · 050577a · 050577a
1 parent 902fd94
commit 050577a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/android-sdk/src/test/java/co/elastic/otel/android/internal/time/ntp/UdpClientTest.kt b/android-sdk/src/test/java/co/elastic/otel/android/internal/time/ntp/UdpClientTest.kt
@@ -37,14 +37,13 @@ class UdpClientTest {
 
     companion object {
         private const val SERVER_HOST = "localhost"
-        private const val SERVER_PORT = 4447
     }
 
     @BeforeEach
     fun setUp() {
-        server = TestUdpServer(SERVER_PORT)
+        server = TestUdpServer()
         server.start()
-        client = UdpClient(SERVER_HOST, SERVER_PORT, 256)
+        client = UdpClient(SERVER_HOST, server.getPort(), 256)
     }
 
     @AfterEach
@@ -99,7 +98,7 @@ class UdpClientTest {
 
     @Test
     fun `Server port is not reachable`() {
-        client = UdpClient(SERVER_HOST, SERVER_PORT + 1, 256)
+        client = UdpClient(SERVER_HOST, server.getPort() + 1, 256)
 
         assertThrows<SocketTimeoutException> {
             client.send("Example".toByteArray(), Duration.ofSeconds(1))
@@ -117,7 +116,7 @@ class UdpClientTest {
 
     @Test
     fun `Server host not found`() {
-        client = UdpClient("nonexistent", SERVER_PORT, 256)
+        client = UdpClient("nonexistent", 1, 256)
         assertThrows<UnknownHostException> {
             client.send("Example".toByteArray())
         }

diff --git a/android-sdk/src/test/java/co/elastic/otel/android/testutils/TestUdpServer.kt b/android-sdk/src/test/java/co/elastic/otel/android/testutils/TestUdpServer.kt
@@ -22,9 +22,9 @@ import java.net.DatagramPacket
 import java.net.DatagramSocket
 import java.net.SocketException
 
-class TestUdpServer(port: Int) : Thread() {
+class TestUdpServer : Thread() {
     private val buf = ByteArray(256)
-    val socket = DatagramSocket(port)
+    val socket = DatagramSocket()
 
     @Volatile
     var responseHandler: (DatagramPacket) -> Unit = { clientPacket ->
@@ -53,4 +53,8 @@ class TestUdpServer(port: Int) : Thread() {
     fun close() {
         socket.close()
     }
+
+    fun getPort(): Int {
+        return socket.localPort
+    }
 }