Merge pull request #375 from ej2/minor-version-deprecation

Add warning for unsupported minorversion
ej2 · Feb 10, 2025 · 8d38c63 · 8d38c63
2 parents 045cded + a639f26
commit 8d38c63
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/quickbooks/client.py b/quickbooks/client.py
@@ -5,6 +5,7 @@
 import hashlib
 import hmac
 import decimal
+import warnings
 
 from . import exceptions
 from requests_oauthlib import OAuth2Session
@@ -19,6 +20,7 @@ class Environments(object):
 
 
 class QuickBooks(object):
+    MINIMUM_MINOR_VERSION = 75
     company_id = 0
     session = None
     auth_client = None
@@ -77,6 +79,12 @@ def __new__(cls, **kwargs):
         if 'minorversion' in kwargs:
             instance.minorversion = kwargs['minorversion']
 
+            if instance.minorversion < instance.MINIMUM_MINOR_VERSION:
+                warnings.warn(
+                    'Minor Version no longer supported.'
+                    'See: https://blogs.intuit.com/2025/01/21/changes-to-our-accounting-api-that-may-impact-your-application/',
+                    DeprecationWarning)
+
         instance.invoice_link = kwargs.get('invoice_link', False)
 
         if 'verifier_token' in kwargs:

diff --git a/tests/unit/test_client.py b/tests/unit/test_client.py
@@ -1,4 +1,5 @@
 import json
+import warnings
 from tests.integration.test_base import QuickbooksUnitTestCase
 
 try:
@@ -31,12 +32,28 @@ def test_client_new(self):
         self.qb_client = client.QuickBooks(
             company_id="company_id",
             verbose=True,
-            minorversion=4,
+            minorversion=75,
             verifier_token=TEST_VERIFIER_TOKEN,
         )
 
         self.assertEqual(self.qb_client.company_id, "company_id")
-        self.assertEqual(self.qb_client.minorversion, 4)
+        self.assertEqual(self.qb_client.minorversion, 75)
+
+    def test_client_with_deprecated_minor_version(self):
+        with warnings.catch_warnings(record=True) as w:
+            self.qb_client = client.QuickBooks(
+                company_id="company_id",
+                verbose=True,
+                minorversion=74,
+                verifier_token=TEST_VERIFIER_TOKEN,
+            )
+
+            warnings.simplefilter("always")
+            self.assertEqual(self.qb_client.company_id, "company_id")
+            self.assertEqual(self.qb_client.minorversion, 74)
+            self.assertEqual(len(w), 1)
+            self.assertTrue(issubclass(w[-1].category, DeprecationWarning))
+            self.assertTrue("Minor Version no longer supported." in str(w[-1].message))
 
     def test_api_url(self):
         qb_client = client.QuickBooks(sandbox=False)