Merge pull request #3 from xris1658/master

Fix traversing operation; prevent crash on writing parameter changes
eimsound · Mar 27, 2023 · af4845c · af4845c
2 parents 79bccd0 + 21f1aeb
commit af4845c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Main.cpp b/src/Main.cpp
@@ -269,13 +269,16 @@ class EIMPluginHost : public juce::JUCEApplication, public juce::AudioPlayHead,
 
     void writeAllParameterChanges() {
         auto time = juce::Time::getApproximateMillisecondCounter();
-        for (auto it = parameterChanges.begin(); it != parameterChanges.end(); it++) {
+        for (auto it = parameterChanges.begin(); it != parameterChanges.end(); ++it) {
 			if (it->second.second > time) continue;
             writeCerr((char)3);
             writeCerr(it->first);
             writeCerr(it->second.first);
-            parameterChanges.erase(it);
         }
+        std::erase_if(parameterChanges, [time](const decltype(parameterChanges)::value_type node)
+        {
+            return node.second.second <= time;
+        });
     }
 
     template <typename T> inline void writeToHostBuffer(T var) {