Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python output to docker #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added Python output to docker #21

wants to merge 4 commits into from

Conversation

adyoull
Copy link
Contributor

@adyoull adyoull commented Feb 6, 2025

Added python output to docker so that those without discord can view python output of executed scripts.

To add logging output to python in docker so python outputs are visible via docker not requiring discord output
Add python outputs to allow those without discord to see python output in logs via docker
Update docker-compose.yaml
@eelmafia
Copy link
Owner

eelmafia commented Feb 8, 2025

Wouldn't it be better if this was user choice instead of ON by default?

@adyoull
Copy link
Contributor Author

adyoull commented Feb 8, 2025

Wouldn't it be better if this was user choice instead of ON by default?

You could set it to 0 opposed to 1, where it's disabled but then unless you have discord setup you get no outputs from python so don't see if any errors have occured

@eelmafia
Copy link
Owner

eelmafia commented Feb 8, 2025

I was thinking instead of using PYTHONUNBUFFERED maybe adding the option for a flag (defaulted to false) and then change

def send_discord_message(content):
    print(content, flush=FLAG)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants