Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enterprise subsidy to devstack #84

Merged
merged 6 commits into from
Apr 4, 2025
Merged

Add enterprise subsidy to devstack #84

merged 6 commits into from
Apr 4, 2025

Conversation

mfarhan943
Copy link
Contributor

@mfarhan943 mfarhan943 commented Nov 19, 2024 •
edited by UsamaSadiq
Loading

Related Ticket:
#76

Related PR:
openedx/enterprise-subsidy#319

Tasks

  • Add the service in docker-compose.yml file, follow docker-compose.yml file from the source repo.
  • Add dev.shell make command if some extra env variables need to be set
  • Add an entry in check.sh if needed
  • Mount volume in docker-compose-host.yml file
  • Add entry in options.mk file
  • Create provision-IDA_NAME.sh file if needed. Also, add an entry in provision.sh file.
  • Create table in provision.sql file if needed
  • Add an entry in repo.sh file.
  • Add an entry in service_list.rst file.

iamsobanjaved
iamsobanjaved reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions, rest looks good.

@mfarhan943 mfarhan943 force-pushed the farhan/add-enterprise-subsidy branch from 4835844 to 731be3f Compare November 26, 2024 10:36
@mfarhan943
Copy link
Contributor Author

Just a few suggestions, rest looks good.

I have applied the suggestions.

@iamsobanjaved iamsobanjaved linked an issue Feb 11, 2025 that may be closed by this pull request
Add openedx/enterprise-subsidy to devstack #76
Closed
@iamsobanjaved iamsobanjaved force-pushed the farhan/add-enterprise-subsidy branch 4 times, most recently from af0f32f to 0eb6bd9 Compare February 18, 2025 11:56
UsamaSadiq
UsamaSadiq requested changes Mar 17, 2025
View reviewed changes
@iamsobanjaved iamsobanjaved force-pushed the farhan/add-enterprise-subsidy branch from ab2dcf5 to 9882734 Compare March 28, 2025 15:05
@iamsobanjaved iamsobanjaved requested a review from UsamaSadiq April 3, 2025 14:18
@iamsobanjaved iamsobanjaved merged commit 69337bc into master Apr 4, 2025
14 checks passed
@iamsobanjaved iamsobanjaved deleted the farhan/add-enterprise-subsidy branch April 4, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved left review comments

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

@huniafatima-99 huniafatima-99 huniafatima-99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add openedx/enterprise-subsidy to devstack
4 participants
@mfarhan943 @UsamaSadiq @iamsobanjaved @huniafatima-99