feat: add auth-request part #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url: string, | ||
| headers: dict, | ||
| token-duration: s64, | ||
| token-response-property: string, |
There was a problem hiding this comment.
@alexcasalboni we might need more than one token right ?
There was a problem hiding this comment.
for the AWS API (link), the response will include a Credentials property, which is a JSON object (see this structure).
So we could be ok with a single property, but we need to force the component developer to serialize and deserialize into/from string.
Also, I was wondering where that property is going to be injected in the settings - do we assume that we can use the same property? (like settings.Credentials if token-response-property=Credentials)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Describe your changes here
Related Issues
List related issues here