Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add diff #86

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat: add diff #86

merged 1 commit into from
Oct 31, 2024

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Oct 30, 2024 •
edited
Loading

Fix #79

Tentatively integrates https://diff2html.xyz/ for result vs original diff for a transform job record.

Not quite there yet:

  • indentation diffs: I don't really understand why, since we're applying the same xml_to_string to result and original
  • node ordering looks different
Capture d’écran 2024-10-30 à 16 11 21

@abulte
Copy link
Contributor Author

abulte commented Oct 30, 2024

indent seems to have done the trick 😎 And I guess geonet:info is fixed by #81.

Capture d’écran 2024-10-30 à 16 33 03

@abulte abulte marked this pull request as ready for review October 30, 2024 15:41
@abulte abulte requested a review from streino October 30, 2024 15:42
streino
streino reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@streino streino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to make my life so much easier ✌️ Going to try right away!

streino
streino reviewed Oct 31, 2024
View reviewed changes
@abulte
Copy link
Contributor Author

abulte commented Oct 31, 2024

What the hell happened with the diff? 😫

@abulte
Copy link
Contributor Author

abulte commented Oct 31, 2024

What the hell happened with the diff? 😫

Rebased.

streino
streino approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@streino streino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we live without this for so long...? :D

@abulte abulte merged commit 7ab6839 into main Oct 31, 2024
1 check passed
@abulte abulte deleted the feat/diff branch October 31, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streino streino streino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display diff of original/result
2 participants
@abulte @streino