Virtual height levels on sfc #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geier1993
previously approved these changes
Apr 9, 2025
| matchType("levtype", "sfc"), | ||
| matchParam(["165:166", 207, 228029, "228131:228132"]), | ||
| ], | ||
| [PointInTime(), levelConfig("heightAboveGroundAt10m")], |
There was a problem hiding this comment.
looks good in this file. Just can not say if the param mapping is correct.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #86 +/- ##
===========================================
- Coverage 54.11% 53.44% -0.68%
===========================================
Files 223 219 -4
Lines 15051 14820 -231
Branches 1246 1246
===========================================
- Hits 8145 7920 -225
+ Misses 6906 6900 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsarmany
force-pushed
the
feature/height-levels-on-sfc
branch
from
e127c5e to
1bb8cc6
Compare
At close to the ground and/or sea, these are mapped to 'levtype=sfc'. Introduce separate, virtual values of 'typeOfLevel' for these to break the inconsistency.
dsarmany
force-pushed
the
feature/height-levels-on-sfc
branch
from
1bb8cc6 to
41664da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.