Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use Xarray earthkit backend for GRIB data #591

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Only use Xarray earthkit backend for GRIB data #591

merged 1 commit into from
Jan 22, 2025

Conversation

sandorkertesz
Copy link
Collaborator

Fixes #579

@sandorkertesz sandorkertesz changed the base branch from develop to main January 22, 2025 12:05
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4df69c6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/readers/test_geotiff_reader.py 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage        ?   90.10%           
=======================================
  Files           ?      151           
  Lines           ?    11171           
  Branches        ?      529           
=======================================
  Hits            ?    10066           
  Misses          ?      936           
  Partials        ?      169

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz changed the title Only use earthkit Xarray engine for GRIB data Only use Xarray earthkit backend for GRIB data Jan 22, 2025
@sandorkertesz sandorkertesz merged commit ef3b9c4 into main Jan 22, 2025
110 checks passed
@sandorkertesz sandorkertesz deleted the bugfix/xarray-engine-non-grib branch January 22, 2025 12:54
@sandorkertesz sandorkertesz mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xarray engine tries and fails to open GeoTIFF instead of letting rasterio take precedence
2 participants
@sandorkertesz @codecov-commenter