Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use FileNotFoundError when no file found rather than FileExistsError #479

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Oct 8, 2024

When no file found to read from, a FileExistsError was being thrown,
Would FileNotFoundError be more apt?

@FussyDuck
Copy link

FussyDuck commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@HCookie HCookie force-pushed the fix-change-exception-type branch from 1777746 to 3d23654 Compare October 8, 2024 15:16
@sandorkertesz
Copy link
Collaborator

I agree. I see now the test has been updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (09c6cba) to head (3d23654).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #479   +/-   ##
========================================
  Coverage    90.92%   90.92%           
========================================
  Files          139      139           
  Lines         9532     9532           
  Branches       829      829           
========================================
  Hits          8667     8667           
  Misses         713      713           
  Partials       152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit b1cc6f5 into develop Oct 8, 2024
113 checks passed
@HCookie HCookie deleted the fix-change-exception-type branch October 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants