-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor streaming #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that suggestion (what do you think @sandorkertesz?), I think this looks really really nice - a good and more intuitive way of doing things.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for clearing up the interface.
Fixes #364
This PR:
batched()
andgroup_by()
for stream and fieldlist like objectsread_all
option forfrom_source()
whenstream=True
batch_size
andgroup_by
options fromfrom_source
(This is a breaking change!)Examples
Documentation
batched
: https://earthkit-data--371.org.readthedocs.build/en/371/_api/data/core/fieldlist/index.html#data.core.fieldlist.FieldList.batchedgroup_by
https://earthkit-data--371.org.readthedocs.build/en/371/_api/data/core/fieldlist/index.html#data.core.fieldlist.FieldList.group_byNotebooks
https://earthkit-data--371.org.readthedocs.build/en/371/examples/data_from_stream.html
https://earthkit-data--371.org.readthedocs.build/en/371/examples/url_stream.html
https://earthkit-data--371.org.readthedocs.build/en/371/examples/fdb.html