feat: add code coverage report #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'internal', 'enhancement', 'breaking-change', 'new feature', 'bug', 'documentation', 'dependencies'} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1808 +/- ##
=======================================
Coverage ? 70.44%
=======================================
Files ? 358
Lines ? 64584
Branches ? 0
=======================================
Hits ? 45496
Misses ? 19088
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Once this ticket is solved, we can merge this PR: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5695 |
Some tests like router_linkstate and three_node_combination are hanging when executed under llvm-cov, for now skip them
diogomatsubara
force-pushed
the
add-code-cov-report
branch
from
fc41a20 to
767ec19
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few caveats
--skipa few tests that were hanging during CI runs underllvm-cov(e.g.router_linkstate,three_node_combination,three_node_combination_multicast). Those tests pass during normal unit tests runs, not sure why they hang when executed under llvm-cov--doctestsoption--ignore-run-failso we upload the code coverage report even if the tests fail. We still have flaky tests that causes failures, which end up cancelling the report upload step.eclipse-zenho/.eclipsefdn. The token is used for reports on protected branches, like zenoh main.