Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading warning for qos overwrites starting with **/ #1805

Closed
Hugal31 opened this issue Feb 28, 2025 · 0 comments · Fixed by #1806
Closed

Misleading warning for qos overwrites starting with **/ #1805

Hugal31 opened this issue Feb 28, 2025 · 0 comments · Fixed by #1806
Labels
bug Something isn't working

Comments

@Hugal31
Copy link
Contributor

Hugal31 commented Feb 28, 2025

Describe the bug

When writing a QoS overwrite with a key expression starting with **/, PublisherBuilder::apply_qos_overwrites emits the following warning:

WARN main ThreadId(01) zenoh::api::builders::publisher: Publisher declared on `demo/example/zenoh-rs-pub` which is included by multiple key_exprs in qos config. Using qos config for `**/demo/**`

This is misleading, as after inspection, the only other "overwrite" is actually an empty overwrite for the ** key. I may be wrong but I believe this is due to the tree nature of the publisher_qos_tree.

A way to only emit this warning when relevant would be to filter on nodes with a non empty QoS ovewrite. I can make a PR for that.

P.S.: I have noticed when there are actually multiple overwrite, the one applied can vary between launches.

To reproduce

Start the z_pub example with the following configuration:

{
  qos: {
    publication: [
      {
        key_exprs: ["**/demo/**"],
        config: {
          priority: "data_high",
        },
      },
    ],
  },
}

System info

  • Platform: Archlinux
  • Zenoh 2311334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant