Support Notification-style Publish. #9
Conversation
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
|
Hey @sophokles73 -- can I have you take a look at this to make sure I asked @evshary to do the right thing? We're trying to handle Notification-style |
| name: "body.access".to_string(), | ||
| version_major: Some(1), | ||
| id: Some(1234), | ||
| fn create_utransport_uuri(index: u8) -> UUri { |
There was a problem hiding this comment.
Is the idea that you'd in the future keep adding more UUris in here for testing purposes and you want to have a single factory function for creating them?
There was a problem hiding this comment.
You're right. That's my intention.
Feel free to give me your opinions about this. I'm still wondering whether there is a more elegant way to do so.
| @@ -482,7 +482,13 @@ impl UTransport for UPClientZenoh { | |||
| ) | |||
| })?; | |||
| // Get Zenoh key | |||
| let topic = attributes.clone().source; | |||
| let topic = if attributes.sink.is_some() { | |||
There was a problem hiding this comment.
Yup, seems like this is what we need 🙂
Just wanna get some input from @sophokles73
There was a problem hiding this comment.
It is correct to assume that you are dealing with a Notification if sink is not empty and a Publish otherwise.
As @PLeVasseur mentioned in #6, support Notification-style Publish.