Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPC implementation to handle message UUIDs correctly #10

Closed
PLeVasseur opened this issue Mar 6, 2024 · 2 comments
Closed

Update RPC implementation to handle message UUIDs correctly #10

PLeVasseur opened this issue Mar 6, 2024 · 2 comments

Comments

@PLeVasseur
Copy link
Contributor

Highlighting a comment I made on a previous PR:

I think this RPC flow still needs some thought though.

We should not be creating a new UUIDBuilder here and getting the reqid from it. I believe this is where the UUIDBuilder that's been constructed already for the uE sending the request should be used.

As is stated over here in the UUID spec, the rand_b portion of the UUID is used to uniquely identify the uE, thus it should be "stable" and thus we should use the UUIDBuilder already associated with this uE.

I suppose that may mean that on construction, you'd need to construct a UUIDBuilder and then use it within RpcClient::invoke_method().

WDYT?

@evshary
Copy link
Contributor

evshary commented Mar 7, 2024

Make sense. I'll see how to make the changes

@evshary
Copy link
Contributor

evshary commented Apr 17, 2024

Close with #24

@evshary evshary closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants