Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: issues in RpcClientServerTest.cpp #103

Open
debruce opened this issue Aug 15, 2024 · 0 comments
Open

clang-tidy: issues in RpcClientServerTest.cpp #103

debruce opened this issue Aug 15, 2024 · 0 comments

Comments

@debruce
Copy link
Contributor

debruce commented Aug 15, 2024

  1. to_string() should be marked nodiscard at line 48
  2. destructor should be marked with override at 73
  3. Bogus if-the-else error in gtest macros: lines 103, 120, 122
  4. gtest EXPECT_NO_THROW has hidden goto in it: line 110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@debruce