Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: issues in ZenohUTransportTest.cpp #100

Open
debruce opened this issue Aug 15, 2024 · 0 comments
Open

clang-tidy: issues in ZenohUTransportTest.cpp #100

debruce opened this issue Aug 15, 2024 · 0 comments

Comments

@debruce
Copy link
Contributor

debruce commented Aug 15, 2024

  1. do not use namespace using-directives; use using-declarations instead (line 23)
  2. destructor should be annotated with override at line 40
  3. unused variables: authority (line48)
  4. TestBody has "cognitive complexity of 28 (threshold 25)". clang-tidy has failed the cognitive complexity test due to gtest macros, probably. This test case is as understandable as any.
  5. Another bogus if-then-else complaint, but this time buried in gtest macros at line 84

clang-tidy was 95% useless on this gtest file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant