Initial commit for updating vsomeip python transport to 1.5.8 release #7
Conversation
DivyaVuppala
force-pushed
the
communication-layer-changes
branch
4 times, most recently
from
4270457 to
9e8423f
Compare
DivyaVuppala
force-pushed
the
communication-layer-changes
branch
from
9e8423f to
7d9124a
Compare
| data: bytearray, | ||
| request_id: int, | ||
| _: int, |
There was a problem hiding this comment.
what is this and why isn't it being used?
There was a problem hiding this comment.
Underlying Vsomeip python library callbacks have a callback method definition, one of the attributes is request_id = client+session_id
In case of event handling we don't do anything with this attribute as all we need is service_id, instance_id, event_id data, message_type
| def _on_service_sending_response_handler( | ||
| self, | ||
| message_type: int, | ||
| _: int, |
There was a problem hiding this comment.
same question here, what's going on with these underscores
There was a problem hiding this comment.
this is an extra callback we register to service to save the umessage responses data based on clientid+sessionid
we don't need the other attributes are hence not named
There was a problem hiding this comment.
This file is really big... can you separate all those handlers into their own package/file?
No description provided.