Align to v1.6.0-alpha.3 spec #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dmacattack
reviewed
Aug 16, 2024
example-utils/integration-test-utils/src/integration_test_utils.rs
Outdated
Show resolved
Hide resolved
* Update to up-rust crates.io release * Update up-linux-streamer and up-linux-streamer-plugin * Update examples * Update to match Zenoh 1.0.0-alpha.6 API * Zenoh Config ListenConfig based on alpha.6 API * Add Zenoh plugins feature as it's now behind a feature flag * Update UPTransportZenoh uses since it takes a "uri" instead of a UUri * Made ustreamer_uuri configurable from config file Implements [#25]
PLeVasseur
force-pushed
the
feature/up-to-crates.io-up-rust
branch
from
39ddd8a to
fcb39e1
Compare
PLeVasseur
changed the title
PLeVasseur
requested review from
dmacattack,
sophokles73 and
evshary
and removed request for
dmacattack
dmacattack
approved these changes
Aug 17, 2024
|
|
||
| // Add the IPv4 endpoint to the Zenoh configuration | ||
| zenoh_config | ||
| .listen | ||
| .endpoints | ||
| .push(ipv4_endpoint.expect("FAIL")); | ||
| .set_endpoints(zenoh::config::ModeDependentValue::Unique(vec
There was a problem hiding this comment.
Yeah, maybe should import the enum to shorten the line.
evshary
approved these changes
Aug 17, 2024
|
|
||
| trace!("streamer_uuri: {streamer_uuri:#?}"); | ||
| let streamer_uri: String = (&streamer_uuri).into(); | ||
| // TODO: Remove this once the error reporting from UPTransportZenoh no longer "hides" |
sophokles73
approved these changes
Aug 19, 2024
| authority: "linux", | ||
| // Determines the ue_id of the streamer | ||
| // Used when initializing host transport | ||
| ue_id: 78, |
There was a problem hiding this comment.
since you are using json5, you might also want to write this as a hex number (as we do all across the Rust code) ...
| authority: "linux", | ||
| // Determines the ue_id of the streamer | ||
| // Used when initializing host transport | ||
| ue_id: 78, |
| if let Some(first_msg) = group.first() { | ||
| let mut prev_msb = first_msg.attributes.as_ref().unwrap().id.msb; | ||
| let mut prev_timestamp = first_msg.attributes.as_ref().unwrap().id.msb >> 16; |
There was a problem hiding this comment.
maybe https://docs.rs/up-rust/0.1.5/up_rust/struct.UUID.html#method.get_time comes in handy here?
There was a problem hiding this comment.
Good point, I should use this. Will do in follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements [#25]
TODO: