Remove the deprecated LocalDependencyResolver #1695
Closed
+0
−524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is actually only used in tests, now we have the option to move this to tycho-core (see eclipse-tycho#1694 ) we can finally get rid of it. Fixes eclipse-tycho#486
laeubi
force-pushed
the
remove_deprecated_local_resolver
branch
from
3e6b1b5 to
354ef62
Compare
|
@akurtakov maybe also something you want to look into? It seems there are still some codes rely on the no longer used Localresolver. |
Sorry for not being really responsive lately, I'm quite busy with other tasks but will try to come back to tycho when things calm down a bit. |
|
No problem, this is lingering around for such a long time we are not in hurry here.. |
|
I think first step is to remove the P2TestStubResolver! this currently seem to hide some (possible) regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is actually only used in tests, now we have the option to move this to tycho-core (see #1694 ) we can finally get rid of it.
Fixes #486