Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API evolution on vscode builtins build process #136

Open
rschnekenbu opened this issue Jan 13, 2025 · 0 comments
Open

API evolution on vscode builtins build process #136

rschnekenbu opened this issue Jan 13, 2025 · 0 comments

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Jan 13, 2025

Since microsoft/vscode@3051342#diff-e22182660ab607268f41de1a913f34ec1af8bcc5644be5782f9269b2c150fa24R259, there are some evolutions in the build process with native and non-native extensions. This cause some breakage in the API used to build the builtins for Theia.

evolutions:

  • compileExtensionsBuildTask is not available anymore, may be replaced by compileAllExtensionsBuildTask from vscode/build/gulpfile.extensions.js
  • packageLocalExtensionsStream may be replaced by packageAllLocalExtensionsStream or equivalent from vscode/build/extension.js

I also got some issues when building the new terminal completion extension. I did not have time to further investigate
log:

{
message: "Module not found: Error: Can't resolve 'fs/promises' in '/home/remi/Git/vscode-builtin-extensions/vscode/extensions/terminal-suggest/src'",
  moduleId: 0,
  moduleTrace: [],
  details: "resolve 'fs/promises' in '/home/remi/Git/vscode-builtin-extensions/vscode/extensions/terminal-suggest/src'\n" +
    '  Parsed request is a module\n' +
    '  using description file: /home/remi/Git/vscode-builtin-extensions/vscode/extensions/terminal-suggest/package.json (relative path: ./src)\n' +
    "    Field 'browser' doesn't contain a valid alias configuration\n" +
    '    resolve as module\n' +
    "      /home/remi/Git/vscode-builtin-extensions/vscode/extensions/terminal-suggest/src/node_modules doesn't exist or is not a directory\n" +
    "      /home/remi/Git/vscode-builtin-extensions/vscode/extensions/terminal-suggest/node_modules doesn't exist or is not a directory\n" +
    '      looking for modules in /home/remi/Git/vscode-builtin-extensions/vscode/extensions/node_modules\n' +
    "        /home/remi/Git/vscode-builtin-extensions/vscode/extensions/node_modules/fs doesn't exist\n" +
    '      looking for modules in /home/remi/Git/vscode-builtin-extensions/vscode/node_modules\n' +
    "        /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/fs doesn't exist\n" +
    '      looking for modules in /home/remi/Git/vscode-builtin-extensions/node_modules\n' +
    "        /home/remi/Git/vscode-builtin-extensions/node_modules/fs doesn't exist\n" +
    "      /home/remi/Git/node_modules doesn't exist or is not a directory\n" +
    "      /home/remi/node_modules doesn't exist or is not a directory\n" +
    "      /home/node_modules doesn't exist or is not a directory\n" +
    "      /node_modules doesn't exist or is not a directory",
  stack: "ModuleNotFoundError: Module not found: Error: Can't resolve 'fs/promises' in '/home/remi/Git/vscode-builtin-extensions/vscode/extensions/terminal-suggest/src'\n" +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/Compilation.js:2109:28\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:908:13\n' +
    '    at eval (eval at create (/home/remi/Git/vscode-builtin-extensions/vscode/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:333:22\n' +
    '    at eval (eval at create (/home/remi/Git/vscode-builtin-extensions/vscode/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:512:22\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:150:10\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:775:25\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:992:8\n' +
    '    at /home/remi/Git/vscode-builtin-extensions/vscode/node_modules/webpack/lib/NormalModuleFactory.js:1121:5'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant