Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Theia.Cloud to Theia Cloud and Improve Ingress/Host configuration #59

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Jun 11, 2024

  • move hosts.tls to ingress.tls
  • move hosts.paths.tlsSecretName to ingress.addTLSSecretName
    • default is set to true which is a change for path based installs
  • move hosts.paths to hosts.configuration
  • remove hosts.useServicePortInHostname
    • no replacement
  • move hosts.servicePort to service.port
  • move hosts.serviceProtocol to service.protocol
  • removed hosts.service
    • hosts.configuration.service + hosts.configuration.baseHost
  • removed hosts.landing
    • hosts.configuration.landing + hosts.configuration.baseHost
  • removed hosts.instance
    • hosts.configuration.instance + hosts.configuration.baseHost

Contributed on behalf of STMicroelectronics

eclipse-theia/theia-cloud#314
#59
eclipsesource/theia-cloud-website#33

@jfaltermeier jfaltermeier force-pushed the jf/naming branch 2 times, most recently from 5d05312 to f4a3be5 Compare June 18, 2024 13:19
@jfaltermeier jfaltermeier changed the title WIP Update Theia.Cloud to Theia Cloud Update Theia.Cloud to Theia Cloud Jun 19, 2024
@jfaltermeier jfaltermeier marked this pull request as ready for review June 19, 2024 06:56
Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier changed the title Update Theia.Cloud to Theia Cloud Rename Theia.Cloud to Theia Cloud and Improve Ingress/Host configuration Jun 27, 2024
* move hosts.tls to ingress.tls
* move hosts.paths.tlsSecretName to ingress.addTLSSecretName
  * default is set to true which is a change for path based installs
* move hosts.paths to hosts.configuration
* remove hosts.useServicePortInHostname
  * no replacement
* move hosts.servicePort to service.port
* move hosts.serviceProtocol to service.protocol
* removed hosts.service
  * hosts.configuration.service + hosts.configuration.baseHost
* removed hosts.landing
  * hosts.configuration.landing + hosts.configuration.baseHost
* removed hosts.instance
  * hosts.configuration.instance + hosts.configuration.baseHost
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants