-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename release profile #133
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e39387e
Rename release profile
cstamas 47fcaa4
Merge remote-tracking branch 'origin/main' into release-profile
cstamas ea193a2
Merge remote-tracking branch 'origin/main' into release-profile
cstamas 142b7a8
Add release doco
cstamas acaf7be
Merge remote-tracking branch 'origin/main' into release-profile
cstamas 56fcded
Add more info about signing (as part of release).
cstamas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Releasing Sisu | ||
|
||
## Maven | ||
|
||
Note: Build uses latest `maven-gpg-plugin` and is getting rid "old bad practices" of storing sensitive information in | ||
any Maven configuration file. Hence, on Workstations, users are recommended to have GPG Agent set up and running, | ||
as plugin will make use of it to get the sensitive information. On unattended releases, the use of | ||
BouncyCastle signer is recommended, and use environment variables `MAVEN_GPG_KEY` and `MAVEN_GPG_PASSPHRASE` | ||
to pass over the key material and the passphrase to `maven-gpg-plugin`. | ||
See [maven-gpg-plugin site](https://maven.apache.org/plugins/maven-gpg-plugin/usage.html) for more information. | ||
|
||
### Release steps | ||
|
||
The "usual" Maven release: | ||
* `mvn release:prepare` | ||
* `mvn release:perform` | ||
* project uses https://oss.sonatype.org/ to stage (manual step: close and release staging repository) | ||
|
||
## Site | ||
|
||
TBD |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not the default profile name
release
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it may conflict with out of the box profile, and as you see, release plugin explicitly disables it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the release profile used by project was not "default" anyway, this PR does not change in this respect, just shortens its name (and aligns it, with other "release profiles" like
apache-release
ortakari-release
etc).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't get why we need a project-specific prefix. I like to have the same profile name across all projects, therefore I usually pick
release
. But as it always has been used with some prefix I am fine with keeping it.