Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to improve coverage #122

Closed
wants to merge 1 commit into from
Closed

Add more tests to improve coverage #122

wants to merge 1 commit into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 8, 2024

Sonar reports error due coverage check failing.

The coverage went off related to this change:
bfbca8a

See https://ci.eclipse.org/sisu/job/sisu.inject-sonar/

Sonar reports error due coverage check failing.

The coverage went off related to this change:
bfbca8a
@cstamas cstamas requested review from mcculls and kwin May 8, 2024 10:35
@cstamas cstamas self-assigned this May 8, 2024
@cstamas
Copy link
Member Author

cstamas commented May 8, 2024

Unsure is this needed at all, as it turned out that Eclipse CI (and hence Sonar scans) were defunct since quite some time. After fixing it "quality gate" is passed 🤷

@cstamas cstamas marked this pull request as draft May 8, 2024 12:52
@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

Not needed, closing

@cstamas cstamas closed this May 30, 2024
@cstamas cstamas deleted the coverage branch May 30, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant