Pressing hyperlinks in plugin.xml editor does not lead to location of identifier

[jonahgraham]

Note that the PR #1609 does resolve the apparent bug of #1608, but I don't know if it is an error that attributeMap for nature ids have no associated IConfigurationElement. The result of them not having one could be a bug itself, or by design.

The result of them not having one is that the id link in the screenshot does not lead anywhere. See the check in this code:

eclipse.pde/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/rows/IdAttributeRow.java

Lines 110 to 115 in 5355197

	protected void openReference() {
	Map<String, IConfigurationElement> attributeMap = PDESchemaHelper.getValidAttributes(getAttribute());
	String id = text.getText();
	// TODO this is hackish
	IConfigurationElement element = attributeMap.get(id);
	if (element != null) {

This is the hyperlink I am referring to:

This issue only seems to affect identifiers. Class and file links seem to work fine.

Originally posted by @jonahgraham in #1608

[jonahgraham]

It is not all id links that don't work. I can't tell if there is a regression here, or something that never worked.

Natured ids don't work - defined like this: basedOn="org.eclipse.core.resources.natures/@id"

But content-type Ids do work -defined like this: basedOn="org.eclipse.core.contenttype.contentTypes/content-type/@id"

For example in the UI this link works:

The nulls end up in the map because of this code

eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/util/PDESchemaHelper.java

Lines 105 to 109 in d01561d

	// handle the core style identifier case
	if (path.length == 2) {
	attributesInfo.put(extension.getUniqueIdentifier(), null);
	continue;
	}

The gatherAttributes method only gets configuration elements if basedOn has 3+ segments. Since nature id refs have two segments, they don't work, but content types have three segments so they do work.

AFAICT nothing in this part of the code has changed anytime recently, so I don't think this is a regression.

[jonahgraham]

I'm probably not spending anymore time on this, and I hope if someone want to pick this issue up the above is enough of a starting point.