Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move org.eclipse.ui.trace -> platform.ui #1586

Open
laeubi opened this issue Jan 28, 2025 · 5 comments
Open

Move org.eclipse.ui.trace -> platform.ui #1586

laeubi opened this issue Jan 28, 2025 · 5 comments

Comments

@laeubi
Copy link
Contributor

laeubi commented Jan 28, 2025

PDE currently hosts a plugin named org.eclipse.ui.trace beside its naming it also does not has any dependency to PDE at all. It is also nowhere referenced except from feature org.eclipse.pde

@HannesWell
Copy link
Member

I assume it's in PDE because it's developer tooling and somehow similar to the E4-spies.

@laeubi
Copy link
Contributor Author

laeubi commented Jan 29, 2025

I assume it's in PDE because it's developer tooling and somehow similar to the E4-spies.

As far as I understand it offers to configure the trace levels, what would be more equinox than PDE but then still I wonder why its org.eclipse.ui.trace naming... So I think it could be more generally be in platform.ui I don't really see this is useful only for plugin development.

@mickaelistria
Copy link
Contributor

I think @HannesWell is right, this bundle probably made its way into PDE because it's target audience are "Plug-In Developers".
However, enabling trace could be something that developer may request a user to enable (if the code leverages traces), it's more or less an advanced version of logging. So maybe it'd make sense to put this plugin in main repo and main product independently of PDE, so we know most users can enable trace and we can more easily ask for more details.

@iloveeclipse
Copy link
Member

Yes, tracing is actually generic enough and useful without PDE for reasons Mickael provided.
If someone want to move it for 4.35, it should be done very soon, before M3 in two weeks from now.

@laeubi
Copy link
Contributor Author

laeubi commented Jan 29, 2025

I think there is no immediate need so we can easily wait for next stream open time, but I thought it would be good to discuss already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants