Replace mock object by lombok builder in BuildConfigurationTest class #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com> replace loop for with Stream API Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
* Introduce AbstractHelmMojo class When new Helm goals will be written, this class will serve as a base class. Previously, the HelmMojo class served as both a Helm goal and a base class for other Helm goals (like helm-push and helm-lint). * Implement pull request comments * Add a quick note on the separate integration tests repository
… `jkube-kit/build/api` module Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…onfig/image` + Add an interface `GeneratorManager` in `jkube-kit/config/image` + Rename existing `GeneratorManager` to `DefaultGeneratorManager` that will implement above interface, rather than relying on static method. + Update maven Mojos and AbstractJKubeTask to use GeneratorManager interface method instead of static method Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Remove exclusions for `io.thorntail:microprofile-config`, `io.thorntail:undertow`, `org.jboss.spec.javax.servlet:jboss-servlet-api_4.0_spec` as they seem to be required by the quickstart Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…t method signature (eclipse-jkube#2761)
…tion (eclipse-jkube#2769) + Port KubernetesClientException.launderThrowable to JKubeException so that we can wrap checked exceptions inside it. + Use abovementioned method in ProfileUtil.blendProfileWithConfiguration
…rences from Mojos + Remove ConfigHelper.Customizer interface from AbstractDockerMojo, AbstractJKubeMojos; mojos would directly pass a UnaryOperator<List<ImageConfiguration>> for customize images operation + Add a helper class JKubeMojoUtils to keeping common methods between mojos Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…eratorManager.generate` method There is `prePackagePhase` field present in GeneratorContext, Use the already present context field rather than providing an additional argument to method Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #2806 (2024-03-12T20:32:57Z) ⚙️ JKube E2E Tests (8255229641)
|
arsenalzp
force-pushed
the
removeMock
branch
2 times, most recently
from
28e8e0e to
021bfad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace mock object by lombok builder in BuildConfigurationTest class
Fixes #2756
Type of change
test, version modification, documentation, etc.)
Checklist