Issue-Fix-#2733 chore(test): fixed failing tests in jkube-kit/config/service module #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2803 (2024-03-12T13:25:53Z) ⚙️ JKube E2E Tests (8249422931)
|
rohanKanojia
approved these changes
Mar 12, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
=============================================
+ Coverage 59.36% 70.60% +11.23%
- Complexity 4586 5008 +422
=============================================
Files 500 486 -14
Lines 21211 19449 -1762
Branches 2830 2506 -324
=============================================
+ Hits 12591 13731 +1140
+ Misses 7370 4492 -2878
+ Partials 1250 1226 -24 ☔ View full report in Codecov by Sentry. |
manusa
reviewed
Mar 18, 2024
| @@ -136,7 +136,7 @@ void init(@TempDir Path temporaryFolder) throws Exception { | |||
| .thenReturn(new ArchiveService(AssemblyManager.getInstance(), logger)); | |||
| when(jKubeServiceHub.getBuildServiceConfig().getBuildDirectory()).thenReturn(target.getAbsolutePath()); | |||
| when(jKubeServiceHub.getConfiguration()).thenReturn(JKubeConfiguration.builder() | |||
| .outputDirectory(target.getAbsolutePath()) | |||
| .outputDirectory(target.getName()) | |||
There was a problem hiding this comment.
It would be clearer if we could simply use a string literal here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2733
Fixes #2768
For
JibBuildServiceBuildIntegrationTest:Changed the linux file separators to platform specific file separators.
For
OpenshiftBuildServiceIntegrationTest:Changed the
outputDirectoryto return relative path fortarget.Changed
Dockerfilelocation inbuild_withDockerfileModeAndAssembly_shouldSucceed()tobaseDirectoryType of change
test, version modification, documentation, etc.)
Checklist