Replaced the creation of the temporary directory using the @TempDir JUnit annotation #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2799 (2024-03-11T22:02:51Z) ⚙️ JKube E2E Tests (8240160378)
|
|
@clarenced : Thanks for the PR! There are other occurences where |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2799 +/- ##
=============================================
+ Coverage 59.36% 70.59% +11.23%
- Complexity 4586 5006 +420
=============================================
Files 500 486 -14
Lines 21211 19447 -1764
Branches 2830 2506 -324
=============================================
+ Hits 12591 13728 +1137
+ Misses 7370 4493 -2877
+ Partials 1250 1226 -24 ☔ View full report in Codecov by Sentry. |
|
Hi @rohanKanojia , are you asking to remove all those |
|
@clarenced : You're right. I was referring to those |
…ned as an attribute.
| File dir = Files.createTempDirectory("d-m-p").toFile(); | ||
| File ret = new File(dir, "Dockerfile"); | ||
| try (OutputStream os = new FileOutputStream(ret)) { | ||
| File ret = new File(tempDir, "Dockerfile"); |
There was a problem hiding this comment.
nit, indentation is slightly off here
|
rohanKanojia
approved these changes
Mar 12, 2024
|
@clarenced : Thanks a lot! |
arsenalzp
pushed a commit
to arsenalzp/jkube
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2775
Replaced the creation of the temporary directory with the
@TempDirJUnit annotationtest, version modification, documentation, etc.)
Checklist