refactor (jkube-kit) : Add GeneratorManager interface in jkube-kit/config/image
#2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2766 (2024-03-05T08:31:01Z) ⚙️ JKube E2E Tests (8153053508)
|
rohanKanojia
force-pushed
the
pr/generator-manager-interface
branch
from
7e049f0 to
325b44f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2766 +/- ##
=============================================
+ Coverage 59.36% 70.58% +11.22%
- Complexity 4586 5013 +427
=============================================
Files 500 486 -14
Lines 21211 19462 -1749
Branches 2830 2504 -326
=============================================
+ Hits 12591 13738 +1147
+ Misses 7370 4502 -2868
+ Partials 1250 1222 -28 ☔ View full report in Codecov by Sentry. |
17 tasks
|
needs rebasing |
rohanKanojia
force-pushed
the
pr/generator-manager-interface
branch
from
325b44f to
92a4d7c
Compare
manusa
reviewed
Mar 5, 2024
| @@ -64,6 +65,7 @@ public abstract class AbstractJKubeTask extends DefaultTask implements Kubernete | |||
| protected static final String DOCKER_BUILD_TIMESTAMP = "docker/build.timestamp"; | |||
| protected List<ImageConfiguration> resolvedImages; | |||
| protected DefaultEnricherManager enricherManager; | |||
| protected GeneratorManager generatorManager; | |||
There was a problem hiding this comment.
It's unclear to me why the variable is needed
…onfig/image` + Add an interface `GeneratorManager` in `jkube-kit/config/image` + Rename existing `GeneratorManager` to `DefaultGeneratorManager` that will implement above interface, rather than relying on static method. + Update maven Mojos and AbstractJKubeTask to use GeneratorManager interface method instead of static method Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/generator-manager-interface
branch
from
92a4d7c to
2aa8992
Compare
|
manusa
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor related to #2378 (comment)
GeneratorManagerinjkube-kit/config/imageGeneratorManagertoDefaultGeneratorManagerthat will implement above interface, rather than relying on static method.Type of change
test, version modification, documentation, etc.)
Checklist