refactor (jkube-kit/build) : Move ConfigHelper and related classes to jkube-kit/build/api module
#2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `jkube-kit/build/api` module Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Eclipse JKube CI ReportStarted new GH workflow run for #2765 (2024-03-04T17:20:05Z) ⚙️ JKube E2E Tests (8144123169)
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2765 +/- ##
=============================================
+ Coverage 59.36% 70.53% +11.17%
- Complexity 4586 5005 +419
=============================================
Files 500 485 -15
Lines 21211 19459 -1752
Branches 2830 2505 -325
=============================================
+ Hits 12591 13725 +1134
+ Misses 7370 4509 -2861
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
17 tasks
manusa
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor related to #2378 (comment)
Move ConfigHelper and related classes to from
jkube-kit/build/service/dockertojkube-kit/build/apimoduleMoved classes :
ConfigKeymoved fromorg.eclipse.jkube.kit.build.service.docker.config.handler.property->org.eclipse.jkube.kit.build.api.config.handler.propertyPropertyConfigHandler.javamoved fromorg.eclipse.jkube.kit.build.service.docker.config.handler.property->org.eclipse.jkube.kit.build.api.config.handler.propertyPropertyModemoved fromorg.eclipse.jkube.kit.build.service.docker.config.handler.property->org.eclipse.jkube.kit.build.api.config.handler.propertyValueCombinePolicymoved fromorg.eclipse.jkube.kit.build.service.docker.config.handler.propertytoorg.eclipse.jkube.kit.build.api.config.handler.propertyValueProvidermoved fromorg.eclipse.jkube.kit.build.service.docker.config.handler.propertytoorg.eclipse.jkube.kit.build.api.config.handler.propertyConfigHelpermoved fromorg.eclipse.jkube.kit.build.service.docker.helpertoorg.eclipse.jkube.kit.build.api.helperExternalConfigHandlermoved fromorg.eclipse.jkube.kit.build.service.docker.config.handlertoorg.eclipse.jkube.kit.build.api.helperFormatParameterReplacermoved fromorg.eclipse.jkube.kit.build.service.docker.helpertoorg.eclipse.jkube.kit.build.api.helperImageConfigResolvermoved fromorg.eclipse.jkube.kit.build.service.docker.config.handlertoorg.eclipse.jkube.kit.build.api.helperImageNameFormattermoved fromorg.eclipse.jkube.kit.build.service.docker.helpertoorg.eclipse.jkube.kit.build.api.helperDeleted unused class ExternalConfigHandlerException
Type of change
test, version modification, documentation, etc.)
Checklist