chore: remove child class field from UndeployMojo #2654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balaganesh-a
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2654 (2024-02-11T12:45:19Z) ⚙️ JKube E2E Tests (7861990738)
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2654 +/- ##
=============================================
+ Coverage 59.36% 70.44% +11.08%
- Complexity 4586 4995 +409
=============================================
Files 500 486 -14
Lines 21211 19454 -1757
Branches 2830 2504 -326
=============================================
+ Hits 12591 13704 +1113
+ Misses 7370 4524 -2846
+ Partials 1250 1226 -24 ☔ View full report in Codecov by Sentry. |
|
@BalaganeshA2k : This issue is created for contributors who have already contributed their first PR to project. Could you please look into |
|
Okay Rohan 👍🏻. Will do the first-timers-only.
…On Mon, 12 Feb, 2024, 10:40 am Rohan Kumar, ***@***.***> wrote:
@BalaganeshA2k <https://github.com/BalaganeshA2k> : This issue is created
for contributors who have already contributed their first PR to project.
Could you please look into first-timers-only
<https://github.com/eclipse/jkube/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Afirst-timers-only>type
issues?
—
Reply to this email directly, view it on GitHub
<#2654 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZZXJOEUYACEC5B5ZIMBIDTYTGP5XAVCNFSM6AAAAABDDQF4NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGA3TGNRTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hello Rohan Kumar,
I've raised a PR for first-timers-only type issues
PR: #2664
Thanks
…On Mon, Feb 12, 2024 at 10:40 AM Rohan Kumar ***@***.***> wrote:
@BalaganeshA2k <https://github.com/BalaganeshA2k> : This issue is created
for contributors who have already contributed their first PR to project.
Could you please look into first-timers-only
<https://github.com/eclipse/jkube/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Afirst-timers-only>type
issues?
—
Reply to this email directly, view it on GitHub
<#2654 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZZXJOEUYACEC5B5ZIMBIDTYTGP5XAVCNFSM6AAAAABDDQF4NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGA3TGNRTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2640
Type of change
test, version modification, documentation, etc.)
Checklist
Acceptance Criteria