Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IOException from setUp method in KubernetesConfigViewTaskTest #2633 #2651

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Remove IOException from setUp method in KubernetesConfigViewTaskTest #2633 #2651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e65f45
Remove IOException from setUp method in KubernetesConfigViewTaskTest
danqixu Feb 10, 2024
4c74805
remove unused IOException import
danqixu Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...etes/src/test/java/org/eclipse/jkube/gradle/plugin/task/KubernetesConfigViewTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
*/
package org.eclipse.jkube.gradle.plugin.task;

import java.io.IOException;

import org.eclipse.jkube.gradle.plugin.KubernetesExtension;
import org.eclipse.jkube.gradle.plugin.TestKubernetesExtension;
import org.eclipse.jkube.kit.config.image.build.JKubeBuildStrategy;
Expand All @@ -35,7 +33,7 @@ class KubernetesConfigViewTaskTest {
private TestKubernetesExtension extension;

@BeforeEach
void setUp() throws IOException {
void setUp() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that IOException isn't used anywhere in the class anymore. You also need to remove import java.io.IOException; on line 16

extension = new TestKubernetesExtension();
when(taskEnvironment.project.getExtensions().getByType(KubernetesExtension.class)).thenReturn(extension);
}
Expand Down
Loading