doc : When using a Maven master password you should configure helm → security
#2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should point plugin → configuration → helm → security to your master password file (which normally is something like ~/.m2/settings-security.xml or ~/.settings-security.xml). Signed-off-by: Jurrie Overgoor <eclipse.org@jurr.org>
Eclipse JKube CI ReportStarted new GH workflow run for #2646 (2024-02-09T11:13:23Z) ⚙️ JKube E2E Tests (7843040450)
|
rohanKanojia
changed the title
helm → securityhelm → security
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2646 +/- ##
=============================================
+ Coverage 59.36% 70.45% +11.09%
- Complexity 4586 4994 +408
=============================================
Files 500 486 -14
Lines 21211 19451 -1760
Branches 2830 2504 -326
=============================================
+ Hits 12591 13704 +1113
+ Misses 7370 4522 -2848
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
| @@ -166,7 +166,7 @@ Password: | |||
| ---- | |||
|
|
|||
| This password then can be used in `authConfig`, `docker.password` | |||
| and/or the `<server>` setting configuration. However, putting an | |||
| and/or the <<helm-repository-authentication-credentials-in-settings-xml,`<server>` setting configuration>>. However, putting an | |||
There was a problem hiding this comment.
This authentication section is applicable for both pushing docker and helm registries. Since configuring authentication credentials in settings.xml is a similar process, this should not create confusion.
There was a problem hiding this comment.
Agreed, but what are you suggesting Rohan? I'm not using the plugin to push to Docker registries, so I am a bit hesitant to write documentation for that. Maybe you could push changes to the PR with documentation on pushing Docker registries?
There was a problem hiding this comment.
In my opinion, it's fine as it is.
rohanKanojia
approved these changes
Feb 12, 2024
ShantKhatri
pushed a commit
to ShantKhatri/jkube
that referenced
this pull request
Feb 14, 2024
…clipse-jkube#2646) You should point plugin → configuration → helm → security to your master password file (which normally is something like ~/.m2/settings-security.xml or ~/.settings-security.xml).
Jurrie
deleted the
feature/Add_documentation_on_when_using_Maven_master_password
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you use a Maven master password and want to use
helm-push, this will fail if you do not configurehelm→securityto point to your master password file (which normally is something like~/.m2/settings-security.xml or ~/.settings-security.xml). Documentation did not mention that, so that is added.
Type of change
test, version modification, documentation, etc.)
Checklist