Moving PortMapping class from org.eclipse.jkube.kit.build.api.model to org.eclipse.jkube.kit.common #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o org.eclipse.jkube.kit.common Signed-off-by: zangus <tw_zangus@hotmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #2582 (2024-02-26T08:32:00Z) ⚙️ JKube E2E Tests (8045575813)
|
…api.model to org.eclipse.jkube.kit.common Signed-off-by: zangus <tw_zangus@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2582 +/- ##
=============================================
+ Coverage 59.36% 70.48% +11.12%
- Complexity 4586 5002 +416
=============================================
Files 500 486 -14
Lines 21211 19463 -1748
Branches 2830 2505 -325
=============================================
+ Hits 12591 13718 +1127
+ Misses 7370 4520 -2850
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
|
@spookynutz : This issue also includes replacing |
I wouldn't go that far within this PR. However, it would be good if this change was included in the changelog since (although very unlikely) someone might be using this class. |
|
@spookynutz : Could you please add a line to CHANGELOG.md regarding this change? |
rohanKanojia
added
the
Waiting on feedback
Signed-off-by: zangus <tw_zangus@hotmail.com>
|
Hello, sorry for the long delay for my response .... A bit new to contributing and I forgot about this PR I opened ... @rohanKanojia @manusa for the change of |
|
rohanKanojia
approved these changes
Feb 26, 2024
|
@spookynutz : Could you please mark it ready for review? |
manusa
changed the title
manusa
approved these changes
Feb 26, 2024
We're using Jackson for this purpose. However, the most important part is to create tests that ensure that the serialization/deserialization process preserves the current behavior. You can check the work done in #2484 as an example |
I passed it to ready to review. I'll have a try at adding tests and changing Gson to Jackson in another PR |
manusa
removed
the
Waiting on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #2481
Type of change
test, version modification, documentation, etc.)
Checklist